From: Yao Qi <qiyaoltc@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: find_and_open_source in symtab_to_fullname
Date: Tue, 22 Dec 2015 15:34:00 -0000 [thread overview]
Message-ID: <864mfaebuk.fsf@gmail.com> (raw)
In-Reply-To: <86egelns63.fsf@gmail.com> (Yao Qi's message of "Thu, 17 Dec 2015 13:03:32 +0000")
Yao Qi <qiyaoltc@gmail.com> writes:
> diff --git a/gdb/linespec.c b/gdb/linespec.c
> index b2233b9..ab77e7e 100644
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -1842,7 +1842,14 @@ create_sals_line_offset (struct linespec_state *self,
> fullname = symtab_to_fullname (self->default_symtab);
> VEC_pop (symtab_ptr, ls->file_symtabs);
> VEC_free (symtab_ptr, ls->file_symtabs);
> - ls->file_symtabs = collect_symtabs_from_filename (fullname);
> +
> + if (IS_ABSOLUTE_PATH (fullname))
> + {
> + VEC_safe_push (symtab_ptr, ls->file_symtabs, self->default_symtab);
> + }
> + else
> + ls->file_symtabs = collect_symtabs_from_filename (fullname);
> +
> use_default = 1;
> }
This patch causes a regression,
(gdb) break 37^M
No line 37 in the current file.^M
Make breakpoint pending on future shared library load? (y or [n]) n^M
(gdb) FAIL: gdb.base/expand-psymtabs.exp: Expand psymtabs (got interactive prompt)
looks more thoughts are needed here.
--
Yao (齐尧)
prev parent reply other threads:[~2015-12-22 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 13:03 Yao Qi
2015-12-22 15:34 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864mfaebuk.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).