Re: [PATCH] Add "error_message+" feature to qSupported

[Eli Zaretskii <eliz@gnu.org>]

> From: Alexandra Hájková <ahajkova@khirnov.net>
> Cc: ahajkova@redhat.com
> Date: Sat, 27 Apr 2024 10:52:26 +0200
> 
> From: Alexandra Hájková <ahajkova@redhat.com>
> 
> Check if the gdbserver GDB is communicating with supports
> responding with the error message in an E.message format to GDB's
> packets.
> 
> Add a new 'error_message' feature to the qSupported packet. When GDB
> and gdbserver support this feature then gdbserver is able to send
> errors in the E.message format for the qRcmd and m packets.
> 
> Update qRcmd packet and m packets documentation as qRcmd newly
> accepts errors in a E.message format.
> Previously these two packets didn't support E.message style errors.
> ---
>  gdb/doc/gdb.texinfo | 27 ++++++++++++++++++++++
>  gdb/remote.c        | 56 +++++++++++++++++++++++++++++++++++++++++++--
>  gdbserver/server.cc |  6 +++++
>  gdbserver/server.h  |  5 ++++
>  4 files changed, 92 insertions(+), 2 deletions(-)

Thanks.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 92731c510b2..c589c05db58 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -42888,6 +42888,11 @@ Reply:
>  Memory contents; each byte is transmitted as a two-digit hexadecimal number.
>  The reply may contain fewer addressable memory units than requested if the
>  server was able to read only part of the region of memory.
> +@item E @var{NN}
> +@var{NN} is errno
> +@item E.errtext
> +Alternatively, an error can be sent as a string. This reply is only valid

Two spaces between sentences, please (here and elsewhere in the
patch).

> +if the 'accept-error-message' feature (@pxref{accept-error-message}) is enabled.
          ^^^^^^^^^^^^^^^^^^^^^^
This should be @code{accept-error-message} instead of the quotes.

> +Alternatively, an error can be sent as a string. This reply is only valid
> +if the 'accept-error-message' feature (@pxref{accept-error-message}) is enabled.
          ^^^^^^^^^^^^^^^^^^^^^^
Likewise.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>