From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id EBA913858D28 for ; Sat, 27 Apr 2024 10:03:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBA913858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBA913858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714212220; cv=none; b=oyuWmTxt1oMhJ9O+wogVm3KlBS45geVx2iNtg7LM+AGuzD3kq/RiSFHUu0eTgFEcrJpTNFsewpjExHMwZQQNucaxf3jdWMr4uO6R/Ejmj5TN1mUSYQk7zcSeJSeSlZXIwuEuVII089ZwsjRajg7bGU8GTL/l4JK5trHeNJOg3Bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714212220; c=relaxed/simple; bh=gCzprxPa2gLRxaxMcdYeDt2uBVb+8nXCayM/ReXHZkQ=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=e6+VYSO5TBC1AjEuyc/B/5TDLp2mAvBGR+b7ZKUdHHYOSvDgCh7buxjSabRxV6YnESRWMCHoZznlehbP6baocV+bR2qG0qRrBj0IbSse0JY0mEgaP4pDxqwArzn1pKQbCFJw0XDCUx4NDekWfr9urS15/E354QkZx/rr1IGRMCY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0eu0-0002YA-8J; Sat, 27 Apr 2024 06:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=WJvTuJsFDea66M14n93+vp+LTgyO5moywwMTdEy2qAE=; b=MfHMWe4sEbRKfccEiAGU XpKjqYcMLZa2JtXyyzTytZqadCN47VrxmE/eE8R4bZLvdZ0OTJfqyiXBObRvPUXJFx03HIMZvcEJv yLkS4KSxugwtn7Z4bU2GqP+ZHZQl4a2+p12POHLgWb83Oscj2VaC7L9Z1REd/UEYhXcjgBI32X3qW vpdpG3T69O+9xAcHJlMEzeGZfRQeGOICtGQhwLxOg6/DbM/kN05Y51hUxq0LxyH9syTWWb9uHDG7A CDu4jXJw2GigNIvR2nL3X/GpzT+eo9gZSGBZcNhOPDG2y91lda7EOOgQfeKeieOxqIca5asHQmsIs 1Lyfa3+D3giLsg==; Date: Sat, 27 Apr 2024 13:03:24 +0300 Message-Id: <865xw3w2ab.fsf@gnu.org> From: Eli Zaretskii To: Alexandra =?utf-8?B?SMOhamtvdsOh?= Cc: gdb-patches@sourceware.org In-Reply-To: <20240427085226.2087243-1-ahajkova@khirnov.net> (message from Alexandra =?utf-8?B?SMOhamtvdsOh?= on Sat, 27 Apr 2024 10:52:26 +0200) Subject: Re: [PATCH] Add "error_message+" feature to qSupported References: <20240427085226.2087243-1-ahajkova@khirnov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Alexandra Hájková > Cc: ahajkova@redhat.com > Date: Sat, 27 Apr 2024 10:52:26 +0200 > > From: Alexandra Hájková > > Check if the gdbserver GDB is communicating with supports > responding with the error message in an E.message format to GDB's > packets. > > Add a new 'error_message' feature to the qSupported packet. When GDB > and gdbserver support this feature then gdbserver is able to send > errors in the E.message format for the qRcmd and m packets. > > Update qRcmd packet and m packets documentation as qRcmd newly > accepts errors in a E.message format. > Previously these two packets didn't support E.message style errors. > --- > gdb/doc/gdb.texinfo | 27 ++++++++++++++++++++++ > gdb/remote.c | 56 +++++++++++++++++++++++++++++++++++++++++++-- > gdbserver/server.cc | 6 +++++ > gdbserver/server.h | 5 ++++ > 4 files changed, 92 insertions(+), 2 deletions(-) Thanks. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 92731c510b2..c589c05db58 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -42888,6 +42888,11 @@ Reply: > Memory contents; each byte is transmitted as a two-digit hexadecimal number. > The reply may contain fewer addressable memory units than requested if the > server was able to read only part of the region of memory. > +@item E @var{NN} > +@var{NN} is errno > +@item E.errtext > +Alternatively, an error can be sent as a string. This reply is only valid Two spaces between sentences, please (here and elsewhere in the patch). > +if the 'accept-error-message' feature (@pxref{accept-error-message}) is enabled. ^^^^^^^^^^^^^^^^^^^^^^ This should be @code{accept-error-message} instead of the quotes. > +Alternatively, an error can be sent as a string. This reply is only valid > +if the 'accept-error-message' feature (@pxref{accept-error-message}) is enabled. ^^^^^^^^^^^^^^^^^^^^^^ Likewise. Reviewed-By: Eli Zaretskii