From: Eli Zaretskii <eliz@gnu.org>
To: Max Yvon Zimmermann <max.yvon.zimmermann@campus.tu-berlin.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add wildcard matching to substitute-path rules
Date: Thu, 04 Apr 2024 09:25:08 +0300 [thread overview]
Message-ID: <865xwx8x17.fsf@gnu.org> (raw)
In-Reply-To: <2c4b26c0-2541-44b4-9c37-a296f099a3cd@campus.tu-berlin.de> (message from Max Yvon Zimmermann on Thu, 4 Apr 2024 02:17:47 +0200)
> Date: Thu, 4 Apr 2024 02:17:47 +0200
> From: Max Yvon Zimmermann <max.yvon.zimmermann@campus.tu-berlin.de>
>
> Changes since v1:
>
> The function strip_trailing_directory_separator_and_escape() is now fixed.
>
> I have added a new function validate_substitute_path_pattern() that will validate any pattern during the registration of a new rule. If an invalid pattern is detected, an error message gets printed. I hope this will make the feature more usable. If this check would not be performed an invalid rule would still be visible with 'show substitute-path', but it would never match anything.
>
> Use literal ',' and '\' in the documentation.
>
> Change the example file names in the documentation.
>
> More tests in the testsuite.
Thanks, the documentation parts are okay, but please consider
mentioning in the manual the backslashes in Windows file names, and
the additional escaping needed for them, as I wrote in my other
message.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
prev parent reply other threads:[~2024-04-04 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 0:17 Max Yvon Zimmermann
2024-04-04 6:25 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865xwx8x17.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=max.yvon.zimmermann@campus.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).