public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: gdb-patches@sourceware.org, kevinb@redhat.com, tom@tromey.com,
	blarsen@redhat.com
Subject: Re: [PATCH v4] gdb: Modify the output of "info breakpoints" and "delete breakpoints"
Date: Thu, 22 Feb 2024 08:54:49 +0200	[thread overview]
Message-ID: <865xyhm1ja.fsf@gnu.org> (raw)
In-Reply-To: <20240222033601.1758-1-yangtiezhu@loongson.cn> (message from Tiezhu Yang on Thu, 22 Feb 2024 11:36:01 +0800)

> From: Tiezhu Yang <yangtiezhu@loongson.cn>
> Cc: Kevin Buettner <kevinb@redhat.com>,
> 	Tom Tromey <tom@tromey.com>,
> 	Bruno Larsen <blarsen@redhat.com>,
> 	Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 22 Feb 2024 11:36:01 +0800
> 
> v4: make the lines shorter than 80 columns
> 
>  gdb/breakpoint.c                              | 25 +++++++-----
>  gdb/doc/gdb.texinfo                           | 38 ++++++++++---------
>  gdb/ppc-linux-nat.c                           |  4 +-
>  gdb/testsuite/gdb.arch/i386-dr3-watch.exp     |  2 +-
>  .../gdb.base/annota-input-while-running.exp   |  2 +-
>  gdb/testsuite/gdb.base/break-unload-file.exp  |  4 +-
>  gdb/testsuite/gdb.base/break.exp              | 10 ++---
>  .../gdb.base/breakpoint-in-ro-region.exp      |  2 +-
>  .../continue-after-aborted-step-over.exp      |  2 +-
>  gdb/testsuite/gdb.base/default.exp            |  2 +-
>  gdb/testsuite/gdb.base/del.exp                |  4 +-
>  gdb/testsuite/gdb.base/ena-dis-br.exp         |  2 +-
>  gdb/testsuite/gdb.base/foll-fork.exp          |  6 +--
>  gdb/testsuite/gdb.base/hbreak-unmapped.exp    |  4 +-
>  gdb/testsuite/gdb.base/hbreak2.exp            |  2 +-
>  gdb/testsuite/gdb.base/help.exp               |  3 +-
>  gdb/testsuite/gdb.base/new-ui.exp             |  8 ++--
>  gdb/testsuite/gdb.base/save-bp.exp            |  8 ++--
>  gdb/testsuite/gdb.base/sepdebug.exp           |  2 +-
>  gdb/testsuite/gdb.base/server-del-break.exp   |  4 +-
>  gdb/testsuite/gdb.cp/annota2.exp              |  4 +-
>  gdb/testsuite/gdb.cp/annota3.exp              |  4 +-
>  gdb/testsuite/gdb.cp/ovldbreak.exp            | 10 ++---
>  gdb/testsuite/gdb.cp/save-bp-qualified.exp    |  4 +-
>  .../gdb.dwarf2/dw2-inline-header-1.exp        |  4 +-
>  .../gdb.dwarf2/dw2-inline-header-2.exp        |  8 ++--
>  .../gdb.dwarf2/dw2-inline-header-3.exp        |  4 +-
>  .../gdb.dwarf2/dw2-inline-small-func.exp      |  4 +-
>  gdb/testsuite/gdb.guile/scm-breakpoint.exp    |  6 +--
>  gdb/testsuite/gdb.linespec/cpexplicit.exp     |  4 +-
>  gdb/testsuite/gdb.linespec/explicit.exp       |  4 +-
>  gdb/testsuite/gdb.mi/mi-py-modify-bp.exp      |  2 +-
>  gdb/testsuite/gdb.mi/mi-return.exp            |  2 +-
>  .../gdb.mi/mi-thread-specific-bp.exp          |  2 +-
>  .../gdb.multi/inferior-specific-bp.exp        |  2 +-
>  gdb/testsuite/gdb.opt/inline-small-func.exp   |  4 +-
>  gdb/testsuite/gdb.python/py-breakpoint.exp    |  8 ++--
>  .../gdb.reverse/ppc_record_test_isa_3_1.exp   |  2 +-
>  .../continue-pending-after-query.exp          |  2 +-
>  .../gdb.threads/continue-pending-status.exp   |  6 +--
>  gdb/testsuite/gdb.threads/thread_check.exp    |  4 +-
>  gdb/testsuite/lib/gdb.exp                     |  6 +--
>  gdb/testsuite/lib/mi-support.exp              | 10 ++---
>  gdbserver/mem-break.cc                        |  7 ++--
>  gdbserver/mem-break.h                         |  7 ++--
>  45 files changed, 132 insertions(+), 122 deletions(-)

Thanks.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 79805486dd6..654c4824ebf 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -4343,7 +4343,8 @@ running or not, what process it is, and why it stopped.
>  @end table
>  
>  @menu
> -* Breakpoints::                 Breakpoints, watchpoints, and catchpoints
> +* Breakpoints::                 Breakpoints, watchpoints, tracepoints,
> +				and catchpoints

The last line uses TABs for alignment, but Texinfo source files should
not use TABs, only SPACEs.

Otherwise, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

      parent reply	other threads:[~2024-02-22  6:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  3:36 Tiezhu Yang
2024-02-22  5:03 ` Kevin Buettner
2024-02-22  6:54 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xyhm1ja.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=tom@tromey.com \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).