From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17497 invoked by alias); 16 Oct 2017 09:02:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16738 invoked by uid 89); 16 Oct 2017 09:02:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static., letter X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 09:02:01 +0000 Received: by mail-wm0-f45.google.com with SMTP id f4so894668wme.0 for ; Mon, 16 Oct 2017 02:02:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Lc9i11k/7PZDO8lI5mBm6YpleXjg+kWC6cSEfAg4S9k=; b=m6b5v7bXmYLtH6Jac9sRANslY/gTkDcc4r2mbWEF+ds6TeIcFLimFrt51smrec+qMZ DEaLajlLF4pYgeVfLin1jhDHsjOoicjHdgCG9FOWUZPGAZHl/4rt7p8t854ivHqVvmQm Rvl1kAaIoFs1tZGbmZqZThHvvDxFTm7+pnEH4hS8e4X6lVsYvgPfhQUFQyQgoIB8/QlA 64/87aMw5lKxVZWu7JFt2iHbC78zBaW1jhe4vY+DS1G5LJXLxGlWv4pKHkRHnHFQuuQF FJx3R+yNnx+iRPw7f0Uop17Nv4ExVVtcf8JLOKE4z+WbD6Gb0jabu4bWWv6Is5vRpXN9 f/nQ== X-Gm-Message-State: AMCzsaXXV8IBE9LnzJBV7krZMGwFrj9fwSL8J/C4KUtJrm+NTK3TPNzK N0CTHf4eAp6bNld5fSmw6pwsqQ== X-Google-Smtp-Source: AOwi7QB72TrjVsutcO0g1fakGZsN2JDSPvcwvyIaucLQH1NZEgd+E1VF2ufnfr9SS23xmn0IzGpjPw== X-Received: by 10.223.132.135 with SMTP id 7mr8208727wrg.74.1508144519693; Mon, 16 Oct 2017 02:01:59 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h4sm2926411wre.13.2017.10.16.02.01.58 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 16 Oct 2017 02:01:59 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/8] Constify add_abbrev_prefix_cmd References: <20171013205950.22943-1-tom@tromey.com> <20171013205950.22943-2-tom@tromey.com> Date: Mon, 16 Oct 2017 09:02:00 -0000 In-Reply-To: <20171013205950.22943-2-tom@tromey.com> (Tom Tromey's message of "Fri, 13 Oct 2017 14:59:43 -0600") Message-ID: <8660bfxy7z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00420.txt.bz2 Tom Tromey writes: > This changes add_abbrev_prefix_cmd to take a const-taking callback > function and then fixes the one caller. > > gdb/ChangeLog > 2017-10-13 Tom Tromey > > * breakpoint.c (stop_command): Constify. > * cli/cli-decode.c (struct cmd_list_element): Constify. > * command.h (add_abbrev_prefix_cmd): Constify. As you said in cover letter, breakpoint.c:stop_command needs update as well. You can pull the stop_command change in this patch, and it looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)