From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E75D23858C53 for ; Sat, 7 May 2022 02:19:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E75D23858C53 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 84E2C1E00D; Fri, 6 May 2022 22:19:03 -0400 (EDT) Message-ID: <8663a834-b227-7c55-c59b-7eea51a5ec1d@simark.ca> Date: Fri, 6 May 2022 22:19:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 18/18] Introduce catchpoint class Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220502221553.1394743-1-tom@tromey.com> <20220502221553.1394743-19-tom@tromey.com> From: Simon Marchi In-Reply-To: <20220502221553.1394743-19-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2022 02:19:06 -0000 On 2022-05-02 18:15, Tom Tromey wrote: > This introduces a catchpoint class that is used as the base class for > all catchpoints. init_catchpoint is rewritten to be a constructor > instead. > > This changes the hierarchy a little -- some catchpoints now inherit > from base_breakpoint whereas previously they did not. This isn't a > problem, as long as re_set is redefined in catchpoint. Hi Tom, This causes some regressions: $ ./gdb -q --data-directory=data-directory -nx -ex "catch syscall" /home/smarchi/src/binutils-gdb/gdb/break-catch-syscall.c:295:34: runtime error: member access within null pointer of type 'struct bp_location' The affected tests are gdb.base/catch-syscall.exp gdb.guile/scm-breakpoint.exp gdb.mi/mi-breakpoint-changed.exp Simon