From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
Date: Tue, 03 Oct 2017 11:40:00 -0000 [thread overview]
Message-ID: <867ewc793g.fsf@gmail.com> (raw)
In-Reply-To: <1506957311-30028-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 2 Oct 2017 16:15:11 +0100")
Pedro Alves <palves@redhat.com> writes:
> struct gdbarch *
> default_thread_architecture (struct target_ops *ops, ptid_t ptid)
> {
> - return target_gdbarch ();
> + inferior *inf = find_inferior_ptid (ptid);
> + gdb_assert (inf != NULL);
> + return inf->gdbarch;
> }
It is right, but forgot to mention that we need to update
spu_thread_architecture too,
if (parse_spufs_run (ptid, &spufs_fd, &spufs_addr))
return spu_gdbarch (spufs_fd);
return target_gdbarch ();
it looks wrong to call target_gdbarch. We may need to replace
target_gdbarch with default_thread_architecture.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-10-03 11:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 15:15 [PATCH 0/3] " Pedro Alves
2017-10-02 15:15 ` [PATCH 3/3] " Pedro Alves
2017-10-03 11:36 ` Yao Qi
2017-10-03 11:40 ` Yao Qi [this message]
2017-10-03 12:21 ` Pedro Alves
2017-10-03 14:02 ` Pedro Alves
2017-10-04 10:21 ` Yao Qi
2017-10-04 17:38 ` Pedro Alves
2017-10-05 16:50 ` Ulrich Weigand
2017-10-05 17:08 ` Pedro Alves
2017-12-12 21:33 ` Maciej W. Rozycki
2017-12-13 0:45 ` Pedro Alves
2017-12-13 11:31 ` Maciej W. Rozycki
2017-10-02 15:15 ` [PATCH 2/3] Reimplement support for "maint print registers" with no running inferior yet Pedro Alves
2017-10-03 11:17 ` Yao Qi
2017-10-02 15:15 ` [PATCH 1/3] Redesign mock environment for gdbarch selftests Pedro Alves
2017-10-03 11:06 ` Yao Qi
2017-10-03 12:05 ` Pedro Alves
2017-10-04 10:39 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867ewc793g.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).