From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33350 invoked by alias); 3 Oct 2017 11:40:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32585 invoked by uid 89); 3 Oct 2017 11:40:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:clients, H*r:sk:static. X-HELO: mail-wr0-f170.google.com Received: from mail-wr0-f170.google.com (HELO mail-wr0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Oct 2017 11:40:39 +0000 Received: by mail-wr0-f170.google.com with SMTP id l24so3174419wre.1 for ; Tue, 03 Oct 2017 04:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=xMluRAgGDwGBHfuy0dNDKSVamEn8nvR0mwbM/b2z2BU=; b=VYa/XgX+oFOcWq/b8BuvUbjquKmroXuoFpAYl24we118xroyNWDLXEY3cSURLDNWSb vgcXcZVl+HBVcDINK9Z0wTLMdWLyRpNRiQsRVqIZD6GjJ+73H3MlZ/ICqOLOHygCkxo4 J/Q2iz5lEVw3NeS11NUScHIGCmqzPwUK6nFNcXHx+YX5OHLdBIoXrMwXixmj64thLqIA eg2/a0VsxkCtQZV3zFx+JzAJ70yn2oOZSP8dfhoC4WuFieAxSCOsqkNLwJvQYI3rJKeA 5LEZyrx0jBYNtPTZdU2tXHv23Tgjnh0DIauqU7X/ANij2ubGcs8of2tMpZNiqjT0i/3x vHTA== X-Gm-Message-State: AMCzsaVXk1BRSE0QntUPyUx07ZEAUg8IugyBqYZRViO2dTedFGIqYNpZ oBCAzK+m/hpddGu4YJtKaeBddA== X-Google-Smtp-Source: AOwi7QC50oj6FI7tbcer/4k2IRayrtJuIuA/yqoDwgieIvo6irr/88bU8H37b+BAYodKSM1oB7Memw== X-Received: by 10.223.186.20 with SMTP id o20mr12599959wrg.3.1507030837149; Tue, 03 Oct 2017 04:40:37 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id l37sm13757971wrl.47.2017.10.03.04.40.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 03 Oct 2017 04:40:36 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors References: <1506957311-30028-1-git-send-email-palves@redhat.com> <1506957311-30028-4-git-send-email-palves@redhat.com> Date: Tue, 03 Oct 2017 11:40:00 -0000 In-Reply-To: <1506957311-30028-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 2 Oct 2017 16:15:11 +0100") Message-ID: <867ewc793g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00037.txt.bz2 Pedro Alves writes: > struct gdbarch * > default_thread_architecture (struct target_ops *ops, ptid_t ptid) > { > - return target_gdbarch (); > + inferior *inf =3D find_inferior_ptid (ptid); > + gdb_assert (inf !=3D NULL); > + return inf->gdbarch; > } It is right, but forgot to mention that we need to update spu_thread_architecture too, if (parse_spufs_run (ptid, &spufs_fd, &spufs_addr)) return spu_gdbarch (spufs_fd); return target_gdbarch (); it looks wrong to call target_gdbarch. We may need to replace target_gdbarch with default_thread_architecture. --=20 Yao (=E9=BD=90=E5=B0=A7)