From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113627 invoked by alias); 29 Jun 2015 08:07:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113608 invoked by uid 89); 29 Jun 2015 08:07:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f46.google.com Received: from mail-pa0-f46.google.com (HELO mail-pa0-f46.google.com) (209.85.220.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 29 Jun 2015 08:07:04 +0000 Received: by padev16 with SMTP id ev16so101806374pad.0 for ; Mon, 29 Jun 2015 01:07:03 -0700 (PDT) X-Received: by 10.70.90.103 with SMTP id bv7mr29868605pdb.160.1435565222909; Mon, 29 Jun 2015 01:07:02 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id om4sm41326152pdb.68.2015.06.29.01.07.01 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 29 Jun 2015 01:07:02 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] [GDBServer][AArch64] Use the same break instruction as GDB References: <1435326128-13705-1-git-send-email-pierre.langlois@arm.com> <1435326128-13705-2-git-send-email-pierre.langlois@arm.com> Date: Mon, 29 Jun 2015 08:07:00 -0000 In-Reply-To: <1435326128-13705-2-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Fri, 26 Jun 2015 14:42:07 +0100") Message-ID: <867fqnq6ow.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00599.txt.bz2 Pierre Langlois writes: > gdb/gdbserver/ChangeLog: > > * linux-aarch64-low.c: Remove comment about endianness. > (aarch64_breakpoint): Change type to gdb_byte[]. Set to "brk #0". > (aarch64_breakpoint_at): Change type of insn to gdb_byte[]. Use > memcmp. This patch is OK to me. --=20 Yao (=E9=BD=90=E5=B0=A7)