From: Yao Qi <qiyaoltc@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix ASAN crash for gdb.compile/compile.exp
Date: Tue, 19 May 2015 11:47:00 -0000 [thread overview]
Message-ID: <867fs4ssb6.fsf@gmail.com> (raw)
In-Reply-To: <20150418170138.GA9123@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 18 Apr 2015 19:01:38 +0200")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Hi Jan,
I didn't follow the compile work in GDB very much, so I may ask
something wrong or discussed before.
> Whether the objfile really should be already freed during
> call_function_by_hand_dummy() I am not sure.
Is there any reason we release OBJFILE in the dummy frame dtor? Why
don't we register a cleanup to release in OBJFILE in compile_object_run?
together with releasing compile_module? 'struct compile_module' has a
field objfile, which should be released together with
'struct compile_module' instead of dummy_frame.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-05-19 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 17:01 Jan Kratochvil
2015-05-16 13:20 ` ping: " Jan Kratochvil
2015-05-19 11:47 ` Yao Qi [this message]
2015-05-19 12:35 ` Jan Kratochvil
2015-05-19 13:43 ` Yao Qi
2015-05-19 14:14 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867fs4ssb6.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).