From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by sourceware.org (Postfix) with ESMTPS id DE42F385773A; Thu, 10 Aug 2023 09:22:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE42F385773A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4RM1f00Vb9z9vCG; Thu, 10 Aug 2023 11:22:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1691659320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=crGgyOY2LH/iwLnM+p9jvgDAnpmTFJsSkm25xglXCRg=; b=jIZ0tmSPejqSTRt2S51ZE7+GiLz0qYwhDT6LNFUh4fQma9wbM+/w68qUAgxgKUbxdlRKns XJp+/R3D8IRgHIRBayZWefnknNPA5WLW52qpXAXQMrkjlqUFC+eZutm64DVYg5ImqwA+Fq vK/hnFu64e3yIYqJyKHNdQE+EqXpk8z6VyS+1/OYUgdVAPZPmTlHEVl5i23oCB4IudgoOJ Zd1BgFyeDjtHz27AZdcXqx9zA8EZmuci6pfNB967WnPQrjYqWJMRL1KcP9xuu3WVakYD1X N/CQ7HwTV4CrDoYyT+p6fyY1r8eqap5W0BPZQelBFIsh1i/I+p8xJtgOOAVWWg== References: <20230807111029.2320238-1-arsen@aarsen.me> <20230807111029.2320238-8-arsen@aarsen.me> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Alan Modra Cc: gdb-patches@sourceware.org, binutils@sourceware.org, Iain Sandoe Subject: Re: [PATCH 07/45] configure: Do not build the ununsed libffi shared library. Date: Thu, 10 Aug 2023 11:21:26 +0200 In-reply-to: Message-ID: <868rajb6bt.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 4RM1f00Vb9z9vCG X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alan Modra writes: > On Mon, Aug 07, 2023 at 01:07:10PM +0200, Arsen Arsenovi=C4=87 via Binuti= ls wrote: >> From: Iain Sandoe >>=20 >> We do not use the shared libffi libraray, nor do we install it. >> However, on at least Darwin, the shared version will be picked >> up for testing, so it is preferrable not to build it. >>=20 >> Signed-off-by: Iain Sandoe >>=20 >> ChangeLog: >>=20 >> * Makefile.def: Do not build shared libffi. >> * Makefile.in: Regenerate. >> --- >> Makefile.def | 4 +- >> Makefile.in | 511 +-------------------------------------------------- >> 2 files changed, 3 insertions(+), 512 deletions(-) >>=20 >> diff --git a/Makefile.def b/Makefile.def >> index 2f51f83b043..8f5a5bb1c9e 100644 >> --- a/Makefile.def >> +++ b/Makefile.def >> @@ -187,8 +187,8 @@ target_modules =3D { module=3D libtermcap; no_check= =3Dtrue; >> missing=3Dmaintainer-clean; }; >> target_modules =3D { module=3D winsup; }; >> target_modules =3D { module=3D libgloss; no_check=3Dtrue; }; >> -target_modules =3D { module=3D libffi; no_install=3Dtrue; }; >> -target_modules =3D { module=3D zlib; }; >> +target_modules =3D { module=3D libffi; no_install=3Dtrue; >> + extra_configure_flags=3D'--disable-shared --with-pic= '; }; >> target_modules =3D { module=3D rda; }; >> target_modules =3D { module=3D libada; }; >> target_modules =3D { module=3D libgomp; bootstrap=3D true; lib_path=3D.= libs; }; > > This one does more than the corresponding gcc patch, removing zlib > too. Hmm, you add back zlib in PATCH 36/45 so something went wrong > here. Hmm, that's odd. Probably an error during conflict resolution. I'll amend locally. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZNSsNl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTLCcBAI1Ok//WCEvocLXx6zvurpQNwLyPlRr7V6Mu 1jkDf+XCAQCqtCDcvo5z5dc4s4Ax0WtXuZIlCHhXU0napakP8ieQBQ== =Wkf8 -----END PGP SIGNATURE----- --=-=-=--