From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84856 invoked by alias); 21 Jun 2016 07:34:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84845 invoked by uid 89); 21 Jun 2016 07:34:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1394 X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 21 Jun 2016 07:34:30 +0000 Received: by mail-pf0-f196.google.com with SMTP id c74so786909pfb.0 for ; Tue, 21 Jun 2016 00:34:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=/mj/GO2CJ5Ds2lK0IN0a/pBZ8VyRH29qy4kAv2j2NJY=; b=QHu3tG/r94vtkqCVpxanWwkw7YsAyBXlTmqY46m4+KstJ0Lw/p7bzzGVjsFPVmYKS/ JtSJxiFUiJvxikH4vty3ETW39LyBd2urlzcejiVI5790SGSIbflNF6p/2KNm/3LnCwyD 8+rowt3o+7dBpwvlqWP+R35vWGXoOTufvF0mPGTvzrnMK86ELkXy30xOE5X5mhgEFFiR OMFKp36zH/UUNgiqnvu2iqBhmWxyYD1QrmRN48cNu3YNNwZzX7HSBCv+DBd+UCGl0AlL HY/yznPrtNzleODFrv4GgPyrSFUHY39NsarFImqV1h6Lsn4TqyyXXK3JcXjIzAkWNtWn Svsw== X-Gm-Message-State: ALyK8tKyVJkKlZKrDcl/+wxZ66dmmgStxYZCSp74h6bPTencUeEWhlmTlrF0lgBd/seYTw== X-Received: by 10.98.206.77 with SMTP id y74mr26448010pfg.55.1466494468736; Tue, 21 Jun 2016 00:34:28 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id 81sm72128020pfo.74.2016.06.21.00.34.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 21 Jun 2016 00:34:28 -0700 (PDT) From: Yao Qi To: palves@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4 V2] gdbarch software_single_step returns VEC (CORE_ADDR) * References: <1463069912-23472-1-git-send-email-yao.qi@linaro.org> Date: Tue, 21 Jun 2016 07:34:00 -0000 In-Reply-To: <1463069912-23472-1-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Thu, 12 May 2016 17:18:28 +0100") Message-ID: <868txzro5l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00347.txt.bz2 Yao Qi writes: Hi Pedro, Your comments to V1 are addressed in V2. Can you take a look? > This is a step toward changing gdbarch software_single_step to > "F:VEC (CORE_ADDR) *:software_single_step:struct regcache *regcache:regca= che" > as I mentioned https://sourceware.org/ml/gdb-patches/2015-11/msg00591.html > > It isn't trivial to replace frame_info with regcache because it may > break the target that frames have different gdbarch, such as spu, so > I still think about it. In the mean time, I post this series, to let > software_single_step returns VEC (CORE_ADDR) *, and > displaced_step_hw_singlestep can be removed. > > V1 can be found https://sourceware.org/ml/gdb-patches/2016-03/msg00466.ht= ml > The main change, compared with V1, is that we finally remove the global > variable arm_override_mode. During the review to V1, there are two > suggested ways, but they need big changes on gdb target/gdbarch > interfaces. Finally, I get a simpler change in patch 1. The rest of > patches are straightforward. > > I don't include patch "Remove gdbarch method displaced_step_hw_singlestep" > in this series, because it causes regression on aarch64-linux doing > multi-arch debugging, and I am looking at it. > > Regression tested on arm-linux, x86_64-linux and aarch64-linux. --=20 Yao (=E9=BD=90=E5=B0=A7)