From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30954 invoked by alias); 1 Jun 2016 11:28:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30927 invoked by uid 89); 1 Jun 2016 11:28:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=guessed, Frame X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Jun 2016 11:28:23 +0000 Received: by mail-pf0-f193.google.com with SMTP id 62so3331115pfd.3 for ; Wed, 01 Jun 2016 04:28:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4HQwovAbJYWzkg1mpBgOZs6nxwcucmni7/EL4XJkfcc=; b=Nx1XZ3StegZcsRL9ztwoPo8D90L3lRY2aDCN/6DHfTjpX6UtyE2wxYDcJzzC9/X0tn 1vVO88k6xhsYD5XjP9tNIfhfwsrqmU0Qrp3zrWti5bnQ/RltBni7W59uY01V1jQfUzGS NtredVZhWMg8orXGL5xj8wQxsD5IoohNZ0WHCSRFg6wCnILbLx+BFa2CwZ9PxNiW715S z0QAfU9hxtQPOOdxHBS9zSE408KXjUtC5MBwYataMJUS4vJNQltof57Thp6vja2fHS6Z S6WBi6aaDJVgliTcnDEmgP8NIy81Vyb+EmOd6x0HeSDghkxXpr68+1fJNOt1ixk2K8t7 J6zg== X-Gm-Message-State: ALyK8tIdRl2LEOwfdVyhJmY/DTO1dkkvObZIOkJrv6gYGaAr8uMUMGH/1h/pmvVQyxoTPw== X-Received: by 10.98.66.149 with SMTP id h21mr7745734pfd.56.1464780501407; Wed, 01 Jun 2016 04:28:21 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id g11sm47308776pfd.89.2016.06.01.04.28.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 01 Jun 2016 04:28:20 -0700 (PDT) From: Yao Qi To: Yan-Ting Lin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] AndesTech NDS32 port References: <3561f390-ea41-2ee3-a5a9-d870429497c3@gmail.com> Date: Wed, 01 Jun 2016 11:28:00 -0000 In-Reply-To: (Yan-Ting Lin's message of "Sun, 15 May 2016 17:39:15 +0800") Message-ID: <868typxi5r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00016.txt.bz2 Yan-Ting Lin writes: > +enum nds32_regnum > +{ > + /* General purpose registers. */ > + NDS32_R0_REGNUM =3D 0, > + NDS32_R5_REGNUM =3D 5, > + NDS32_TA_REGNUM =3D 15, /* Temporary register. */ > + NDS32_FP_REGNUM =3D 28, /* Frame pointer. */ > + NDS32_GP_REGNUM =3D 29, /* Global pointer. */ > + NDS32_LP_REGNUM =3D 30, /* Link pointer. */ > + NDS32_SP_REGNUM =3D 31, /* Stack pointer. */ > + > + NDS32_PC_REGNUM =3D 32, /* Program counter. */ > + > + NDS32_NUM_REGS, > + > + /* Double precision floating-point registers. */ > + NDS32_FD0_REGNUM =3D NDS32_NUM_REGS, > +}; > + > +struct gdbarch_tdep > +{ > + /* The guessed FPU configuration. */ > + int fpu_freg; > + /* FSRs are defined as pseudo registers. */ > + int use_pseudo_fsrs; > + /* Cached regnum of the first FSR (FS0). */ > + int fs0_regnum; > + /* Cached regnum of the first FDR (FD0). */ > + int fd0_regnum; > + /* ABI info. */ > + int abi; > +}; We can either use NDS32_FD0_REGNUM or gdbarch_tdep.fd0_regnum, IMO. If the register number of fd0 is fixed, we can use NDS32_FD0_REGNUM, otherwise, we need to use gdbarch_tdep.fd0_regnum. If so, we can remove one of them. --=20 Yao (=E9=BD=90=E5=B0=A7)