From: Yao Qi <qiyaoltc@gmail.com>
To: Bernhard Heckel <bernhard.heckel@intel.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH V2 6/7] Fortran, testsuite: Fix duplicate testcase name.
Date: Mon, 23 May 2016 13:22:00 -0000 [thread overview]
Message-ID: <868tz07vur.fsf@gmail.com> (raw)
In-Reply-To: <573B1455.4050004@intel.com> (Bernhard Heckel's message of "Tue, 17 May 2016 14:53:41 +0200")
Bernhard Heckel <bernhard.heckel@intel.com> writes:
>>> gdb_test "ptype fivedynarr(2)" \
>>> [multi_line "type = Type five" \
>>> "\\s+Type one :: tone" \
>>> - "End Type five" ]
>>> + "End Type five" ] \
>>> + "ptype fivedynarr(2), not allocated"
>> I don't understand why do we need this change. Looks the element "tone"
>> of type "five" is not allocated, but type "five" is.
> I found a duplicate testname in the same file, therefore I just added
> a post-fix to the testname.
> This test above handles not allocated elements of an array.
> Specific here, the element of an allocatable array is a struct which
> has the allocatable variable "tone" which is not allocated yet.
> There is not change to the test itself, only the testname
Yes, I know this only changes the test name, but that is confusing. As
I said, variable "tone" is not allocated yet, but variable of type
"five" is. This test is printing the type "five". Probably you can
rename the test to "ptype fivedynarr(2), tone is not allocated".
--
Yao (齐尧)
next prev parent reply other threads:[~2016-05-23 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 9:34 [PATCH V2 0/7] Fortran, typeprint Bernhard Heckel
2016-05-13 9:35 ` [PATCH V2 1/7] Fortran, testsuite: Use multi_line in whatis_type testcase Bernhard Heckel
2016-05-13 14:01 ` Yao Qi
2016-05-13 9:35 ` [PATCH V2 7/7] Fortran, typeprint: Forward level of details to be printed for pointers Bernhard Heckel
2016-05-13 15:57 ` Yao Qi
2016-05-13 9:35 ` [PATCH V2 4/7] Fortran, typeprint: Decrease level of details when printing elements of a structure Bernhard Heckel
2016-05-13 14:12 ` Yao Qi
2016-05-13 9:35 ` [PATCH V2 2/7] Fortran, typeprint: Fix wrong indentation when ptype nested structures Bernhard Heckel
2016-05-13 14:05 ` Yao Qi
2016-05-13 9:35 ` [PATCH V2 6/7] Fortran, testsuite: Fix duplicate testcase name Bernhard Heckel
2016-05-13 14:20 ` Yao Qi
2016-05-17 12:53 ` Bernhard Heckel
2016-05-18 13:29 ` Bernhard Heckel
2016-05-23 11:15 ` [PING][PATCH " Bernhard Heckel
2016-05-23 13:22 ` Yao Qi [this message]
2016-05-13 9:35 ` [PATCH V2 3/7] Fortran, typeprint: Take level of details into account when printing elements of a structure Bernhard Heckel
2016-05-13 15:58 ` Yao Qi
2016-05-13 9:35 ` [PATCH V2 5/7] Fortran, testsuite: Add testcases for nested structures Bernhard Heckel
2016-05-13 14:17 ` Yao Qi
2016-05-25 7:13 ` [PUSHED][PATCH V2 0/7] Fortran, typeprint Bernhard Heckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868tz07vur.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=bernhard.heckel@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).