From: Yao Qi <qiyaoltc@gmail.com>
To: "Heckel\, Bernhard" <bernhard.heckel@intel.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,
gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [PATCH V2 1/2] testsuite: Support detection of Intel compilers via test_compiler_version.
Date: Mon, 18 Apr 2016 09:29:00 -0000 [thread overview]
Message-ID: <868u0bl0yt.fsf@gmail.com> (raw)
In-Reply-To: <57147D6B.9030403@intel.com> (Bernhard Heckel's message of "Mon, 18 Apr 2016 08:23:39 +0200")
"Heckel, Bernhard" <bernhard.heckel@intel.com> writes:
>>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>>> index 1ef6a96..75c5e68 100644
>>> --- a/gdb/testsuite/lib/gdb.exp
>>> +++ b/gdb/testsuite/lib/gdb.exp
>>> @@ -3553,6 +3553,9 @@ proc gdb_compile_shlib {sources dest options} {
>>> lappend obj_options "additional_flags=-fpic"
>>> }
>>> }
>>> + "icc-*" {
>>> + lappend obj_options "additional_flags=-fpic"
>>> + }
>> Why do we need this change? How is it related to this patch series?
> ICC was handled in the testsuite like GCC before, including the flags
> for compiling shared libraries.
> If not set, compiling gdb.fortran/library-module-lib.f90 will fail.
This change affects all the shared lib tests compiled by icc. It should
be in another patch.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-04-18 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 12:46 [PATCH V2 0/2] fortran: Testsuite, fix different type naming across compilers Bernhard Heckel
2016-04-15 12:47 ` [PATCH V2 1/2] testsuite: Support detection of Intel compilers via test_compiler_version Bernhard Heckel
2016-04-15 15:00 ` Yao Qi
2016-04-18 6:26 ` Heckel, Bernhard
2016-04-18 9:29 ` Yao Qi [this message]
2016-04-15 12:47 ` [PATCH V2 2/2] fortran: Testsuite, fix different type naming across compilers Bernhard Heckel
2016-04-15 14:41 ` Yao Qi
2016-04-18 7:15 ` Heckel, Bernhard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868u0bl0yt.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=bernhard.heckel@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).