From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65772 invoked by alias); 18 Apr 2016 09:29:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64502 invoked by uid 89); 18 Apr 2016 09:29:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:896 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 Apr 2016 09:29:19 +0000 Received: by mail-pa0-f47.google.com with SMTP id er2so48729248pad.3 for ; Mon, 18 Apr 2016 02:29:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=tTYKQku7J3ZP81AB9Xig2cbOsTfPm+V+S2EBJE29UuY=; b=cOXHJhxoNZM9y35YkJcOVriYKNP1Z9u4hhwu2n/KnRELOj8PjRcii2MfNAhLDq7B8b yS+epPnx7AtCePi9BI2ueu5angrXM3cxA2Ap5MNPPA+WOSyZ7F86JHbW8yfTLeHtpmmm Ae5fGVlzCzl/IfqSuhXyJdy8vLL5mrBX32oF9k5ZQz2mOTtC8wFVaurRQCABdDaPDNvv Wev4OY+otjsBoiI7rwSvgPC+Gn4p0xUjrk3ILIXZfVt7x1RkDksQ3PtVGfXQnugxVsR7 cQ+AfhyObdQagP825igax9d8UXhyJgBtTLR5qPJvXG2PMU8Ep7+J+Y3qHWvnm7jPi/G5 J/6Q== X-Gm-Message-State: AOPr4FUTJy1nTtHDH6gDeh2BYfOD1HcZBiuUP4hUD8GlFmBn89IHqFwTz5DokD+hzhJaHw== X-Received: by 10.66.149.194 with SMTP id uc2mr48909990pab.116.1460971757872; Mon, 18 Apr 2016 02:29:17 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 67sm20232671pfy.22.2016.04.18.02.29.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 18 Apr 2016 02:29:16 -0700 (PDT) From: Yao Qi To: "Heckel\, Bernhard" Cc: Yao Qi , gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [PATCH V2 1/2] testsuite: Support detection of Intel compilers via test_compiler_version. References: <1460724297-23523-1-git-send-email-bernhard.heckel@intel.com> <1460724297-23523-2-git-send-email-bernhard.heckel@intel.com> <86k2jylxxu.fsf@gmail.com> <57147D6B.9030403@intel.com> Date: Mon, 18 Apr 2016 09:29:00 -0000 In-Reply-To: <57147D6B.9030403@intel.com> (Bernhard Heckel's message of "Mon, 18 Apr 2016 08:23:39 +0200") Message-ID: <868u0bl0yt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00385.txt.bz2 "Heckel, Bernhard" writes: >>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >>> index 1ef6a96..75c5e68 100644 >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -3553,6 +3553,9 @@ proc gdb_compile_shlib {sources dest options} { >>> lappend obj_options "additional_flags=3D-fpic" >>> } >>> } >>> + "icc-*" { >>> + lappend obj_options "additional_flags=3D-fpic" >>> + } >> Why do we need this change? How is it related to this patch series? > ICC was handled in the testsuite like GCC before, including the flags > for compiling shared libraries. > If not set, compiling gdb.fortran/library-module-lib.f90 will fail. This change affects all the shared lib tests compiled by icc. It should be in another patch. --=20 Yao (=E9=BD=90=E5=B0=A7)