From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44991 invoked by alias); 15 Sep 2015 10:10:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44929 invoked by uid 89); 15 Sep 2015 10:10:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f174.google.com Received: from mail-wi0-f174.google.com (HELO mail-wi0-f174.google.com) (209.85.212.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 10:10:16 +0000 Received: by wicge5 with SMTP id ge5so21348915wic.0 for ; Tue, 15 Sep 2015 03:10:13 -0700 (PDT) X-Received: by 10.180.216.108 with SMTP id op12mr5733252wic.43.1442311813213; Tue, 15 Sep 2015 03:10:13 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id xt1sm17200907wjb.32.2015.09.15.03.10.12 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 03:10:12 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] [AArch64] Move instruction decoding into new arch/ directory References: <1442230282-20751-1-git-send-email-pierre.langlois@arm.com> <1442230282-20751-3-git-send-email-pierre.langlois@arm.com> Date: Tue, 15 Sep 2015 10:10:00 -0000 In-Reply-To: <1442230282-20751-3-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Mon, 14 Sep 2015 12:31:16 +0100") Message-ID: <868u883se9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00309.txt.bz2 Pierre Langlois writes: > diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv > index aa232f8..d263381 100644 > --- a/gdb/gdbserver/configure.srv > +++ b/gdb/gdbserver/configure.srv > @@ -50,7 +50,7 @@ case "${target}" in > aarch64*-*-linux*) > srv_regobj=3D"aarch64.o" > srv_regobj=3D"${srv_regobj} arm-with-neon.o" > - srv_tgtobj=3D"linux-aarch64-low.o aarch64-linux-hw-point.o" > + srv_tgtobj=3D"linux-aarch64-low.o aarch64-linux-hw-point.o aarch64-in= sn.o" This line is too lone. Please shorten it like what are doing below. > srv_tgtobj=3D"$srv_tgtobj linux-aarch32-low.o" > srv_tgtobj=3D"$srv_tgtobj aarch64-linux.o" > srv_tgtobj=3D"${srv_tgtobj} $srv_linux_obj" Otherwise, that patch is OK. --=20 Yao (=E9=BD=90=E5=B0=A7)