From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93404 invoked by alias); 30 May 2017 20:44:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93388 invoked by uid 89); 30 May 2017 20:44:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Minor, Various, monster X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 May 2017 20:44:29 +0000 Received: by simark.ca (Postfix, from userid 33) id DD7641E4B1; Tue, 30 May 2017 16:44:31 -0400 (EDT) To: Andreas Arnez Subject: Re: [PATCH v2 00/19] Various DWARF piece fixes X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 30 May 2017 20:44:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com In-Reply-To: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> Message-ID: <8694ad33433a8f7018b98e8d9eb8e574@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00627.txt.bz2 On 2017-05-09 19:45, Andreas Arnez wrote: > This series fixes various issues with DWARF piece handling. > Specifically it almost rewrites the functions read_pieced_value and > write_pieced_value in multiple steps. Test cases are added as well. > > Version 1 is here: > > https://sourceware.org/ml/gdb-patches/2017-04/msg00177.html > > Changes from version 1 include: > > * Split up some patches further. > > * Added two more fixes for memory pieces. > > * Added a "merge" patch at the end. > > * Introduced get_endianness convenience proc for test suite. > > * Minor test case improvement. > > * Comment- and some general readability improvements. Hi Andreas, I went over the patches that Yao hasn't replied on, namely 13, 14, 16, 17 and 19, it all looks good to me (note the little comment on #17). Since it's some tricky code, I wasn't always able to convince myself of the correctness by just looking at it. But I went through the test cases by hand, when applicable, and it gives me enough confidence that the code is correct (or at least more correct than the current code :)). I'm not sure I like the merge of the two functions, already scary by themselves, in one scarier monster, but I understand the downsides of having two separate functions, so I'm ok to go with it. I'll let Yao decide if he wants to go himself through the remaining patches. Simon