From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Replace address and aspace with thread in struct step_over_info
Date: Tue, 19 Apr 2016 13:55:00 -0000 [thread overview]
Message-ID: <86a8kpk8k1.fsf@gmail.com> (raw)
In-Reply-To: <57160BDA.4090104@redhat.com> (Pedro Alves's message of "Tue, 19 Apr 2016 11:43:38 +0100")
Pedro Alves <palves@redhat.com> writes:
> I think this is problematic.
>
> While a thread is being stepped past a breakpoint, it's possible that the
> user sets some other breakpoint, and then we end up in
> stepping_past_instruction_at
> deciding whether we can insert that new breakpoint, while the step-over thread
> is running.
>
> As soon as the step-over thread is resumed for the actual step-over, it's
> regcache is flushed (target_resume -> registers_changed_ptid). From that point
> and until the thread stops again, trying to fetch its regcache will error out,
> because you can't read registers from a thread that is running.
OK, that is a good case. I didn't think of it. I withdraw the patch.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-04-19 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 13:29 [PATCH 0/2] Add thread info in 'struct step_over_info' Yao Qi
2016-04-15 13:29 ` [PATCH 2/2] Replace address and aspace with thread in struct step_over_info Yao Qi
2016-04-19 10:43 ` Pedro Alves
2016-04-19 13:55 ` Yao Qi [this message]
2016-04-20 18:01 ` Doug Evans
2016-04-20 18:03 ` Pedro Alves
2016-12-22 23:51 ` Doug Evans
2016-04-15 13:29 ` [PATCH 1/2] Refactor function set_step_over_info Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a8kpk8k1.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).