From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117914 invoked by alias); 19 Apr 2016 13:55:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117825 invoked by uid 89); 19 Apr 2016 13:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=withdraw X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 19 Apr 2016 13:55:16 +0000 Received: by mail-pa0-f51.google.com with SMTP id zm5so7004960pac.0 for ; Tue, 19 Apr 2016 06:55:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=d1rwQwCXn58KUDZbwxWy5Ntcs6qkSqvdsUaD8VI5nMU=; b=dZHabwfV41S/yToOMcX2KF+lQVhsaC5i6UYpd3v36ePU+LqzkhbwkWX+lNC0cGWOdB QzC/dJL4kO4cfSsA4sK9lPmJv0bWvNYu5q4zc4iCb2J10y/MWXSpJQSsx6WMqWJBMPlA W1Pyy/wKOGb/V+VDA4LA9VYJaQFzurr9gKElaSUHhIBANee1RdGBQEdbtqLdOaWgSMRZ V6TElIwCGiTU/YiqaNStg2TBA01lzsKcrZuS4zkNoJY/1JYsXa/p55PfqlzYwCVPyg+3 qWsyiEN4hWMfKKEX3bW8lE9+H0OdQ5wFPihmeSY2j8w+OEvlAjeTY2lwtt9z6CXmmlkf HSDw== X-Gm-Message-State: AOPr4FVqjunjSifXKE/0UOg7YcFdreUjVG2BrX/XWxOUWR0rz1ZjGCRxYtu2IYLArEFuqg== X-Received: by 10.66.134.15 with SMTP id pg15mr4175267pab.98.1461074114360; Tue, 19 Apr 2016 06:55:14 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id qb1sm24698047pac.44.2016.04.19.06.55.11 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 19 Apr 2016 06:55:13 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Replace address and aspace with thread in struct step_over_info References: <1460726961-27486-1-git-send-email-yao.qi@linaro.org> <1460726961-27486-3-git-send-email-yao.qi@linaro.org> <57160BDA.4090104@redhat.com> Date: Tue, 19 Apr 2016 13:55:00 -0000 In-Reply-To: <57160BDA.4090104@redhat.com> (Pedro Alves's message of "Tue, 19 Apr 2016 11:43:38 +0100") Message-ID: <86a8kpk8k1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00442.txt.bz2 Pedro Alves writes: > I think this is problematic. > > While a thread is being stepped past a breakpoint, it's possible that the > user sets some other breakpoint, and then we end up in > stepping_past_instruction_at > deciding whether we can insert that new breakpoint, while the step-over t= hread > is running. > > As soon as the step-over thread is resumed for the actual step-over, it's > regcache is flushed (target_resume -> registers_changed_ptid). From that= point > and until the thread stops again, trying to fetch its regcache will error= out, > because you can't read registers from a thread that is running. OK, that is a good case. I didn't think of it. I withdraw the patch. --=20 Yao (=E9=BD=90=E5=B0=A7)