From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 392EF3858C66 for ; Wed, 5 Jun 2024 14:21:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 392EF3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 392EF3858C66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717597281; cv=none; b=KHg2pYc6Ururi/O5Wa6X71vfWoAgnxHOXwYBSQLenk3lD1UxKrlaYFQP0R4mIsY7sXx7E6fB0rL+4ZjspnrpPnIPUCgV1igUZi0/ljWzMVGa9wfZFs2r/Hm9wZ7P7Xo+b731kBuIdzFKQJswSkD73Kf1X5XBBphZWYQA1wfs8bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717597281; c=relaxed/simple; bh=YCnGRmc9uHnWISUQSzXzPPWMBvKe8mjEKbkU35O/ins=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=bB7J2lGSQr1eFPalav5AzzJnysjr4uOGFiLQFV8fxVYZUf3v+KUxM0UT2DyPl8HGJ1lZLGEgy4ApHjtr/iU3QsqHGPImmCPAq9Qp6M0yiC7cjMEVAvYiDcm+Qo1qRgyrkQPOH1Q6uwDf9GwuyTcpLXhfX3+31rGUMAlvcQp+mCQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sErVv-0007Et-Js; Wed, 05 Jun 2024 10:21:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1CCT2PtEBiyfXUJ+rMy7IYVf1FRjyMhnahYceUUJAGU=; b=YmNEHvsPP9Xo wWO4p5K/0MoeJ5zsa5naL/4URCUPDA5lk7a/tmEWXvDco3DGxC86ze9B0cLk9tHUUWdWfYfbljHgd C2fbIMPp02JOoVcroAN38WrX++A9BJcQJy1euLewj+POccl/y1rE4QRkd/Dkm/SzsF/GnjGN4DqBN Gn+tw9FfsICHyyaWEBAzJwdp9Ok8DPnN/tl+hqat1gkSeUU5rdpmmnox1AA85dsORI2nxXrOh+vwE xz87z3dnQoZ9wHqzWPv5q/UrdP0YdYJjGcEMvGtO8iQTIKRAvLtSdAvTvcdcZ+8cMOdOSdaY8bBys ov2yOYBurEGgkDDm1+KH/g==; Date: Wed, 05 Jun 2024 17:21:16 +0300 Message-Id: <86bk4fjwrn.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <522334df1701e3910acf9d057b72d2f974025d70.1717592684.git.aburgess@redhat.com> (message from Andrew Burgess on Wed, 5 Jun 2024 14:15:13 +0100) Subject: Re: [PATCH 6/8] gdb: add GDB side target_ops::fileio_stat implementation References: <522334df1701e3910acf9d057b72d2f974025d70.1717592684.git.aburgess@redhat.com> X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Andrew Burgess > Cc: Andrew Burgess > Date: Wed, 5 Jun 2024 14:15:13 +0100 > > This commit adds the GDB side of target_ops::fileio_stat. There's an > implementation for inf_child_target, which just calls 'lstat', and > there's an implementation for remote_target, which sends a new > vFile:stat packet. > > The new packet is documented. > > There's still no users of target_fileio_stat as I have not yet added > support for vFile::stat to gdbserver. If these packets are currently > sent to gdbserver then they will be reported as not supported and the > ENOSYS error code will be returned. > --- > gdb/NEWS | 5 +++ > gdb/doc/gdb.texinfo | 11 ++++++ > gdb/inf-child.c | 15 ++++++++ > gdb/inf-child.h | 2 ++ > gdb/remote.c | 83 +++++++++++++++++++++++++++++++++++++++------ > 5 files changed, 105 insertions(+), 11 deletions(-) Thanks, the documentation parts are okay. Reviewed-By: Eli Zaretskii