From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125018 invoked by alias); 16 Oct 2017 09:59:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125008 invoked by uid 89); 16 Oct 2017 09:59:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 09:59:28 +0000 Received: by mail-wm0-f65.google.com with SMTP id t69so1355091wmt.2 for ; Mon, 16 Oct 2017 02:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Cmu3YqYp/+dmNKOeTQ0wNGQErvy+BVd6hZq5p1LX8CU=; b=ISkZfZ9BqewLPOqrH5hMaRkf4Uw02+rKWjRK2sVeYc/JxEYTelhtnqxlrMMmu1qcEn zm/zgqqnR39rwqpCO7Y3UE2bG4zRx1kv9+KcgISJApKVDa0eHu7JRissW7g+7CwjEol3 Ed4aQ9qpdWg/fOv97xcIgwAlBBdlQQHlU0VeoRWFgVd1gJqJCYG/IIA9ZR7OBm3YHzE/ ML9AdySBtAWJBKyYsHMumRrGbdCiRmJQXS2WkULOTcvsuZVq8fPJ+XJagB0yHCy78k4h RZsICkA/GprUltf30xlQZ9KaX9Zedl+KEF9h5wXSHBFgfUR8ElbMwIJe4Pd2DqI3ZmXL U71Q== X-Gm-Message-State: AMCzsaWJwFitr1ySY2UM1qcwlXB0BWhaZtyjPtgiyP78edXnfud/gjtq bVwKO4GStYxSAAjzAHWqSDd51g== X-Google-Smtp-Source: ABhQp+S4tFaR8ZHxYMwLSpF/O/k+8jtKVMas9OS+F9wHrNlPSmJUfTPsnC31OAOGv+qAlXeR8MFweQ== X-Received: by 10.223.157.203 with SMTP id q11mr23473wre.131.1508147965717; Mon, 16 Oct 2017 02:59:25 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id o18sm12004058wrc.45.2017.10.16.02.59.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 16 Oct 2017 02:59:25 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 8/8] Constify add_com References: <20171013205950.22943-1-tom@tromey.com> <20171013205950.22943-9-tom@tromey.com> Date: Mon, 16 Oct 2017 09:59:00 -0000 In-Reply-To: <20171013205950.22943-9-tom@tromey.com> (Tom Tromey's message of "Fri, 13 Oct 2017 14:59:50 -0600") Message-ID: <86bml7wgzq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00427.txt.bz2 Tom Tromey writes: > 2017-10-13 Tom Tromey > > * solib.h (no_shared_libraries): Constify. > * frame.h (return_command): Constify. > * cli/cli-cmds.h (quit_command): Constify. > * top.h (quit_command, execute_command): Constify. > * target.h (flash_erase_command): Constify. > * inferior.h (set_inferior_args, attach_command): Constify. > * tracepoint.h (start_tracing, stop_tracing): Constify. > * breakpoint.h (break_command, tbreak_command) > (hbreak_command_wrapper, thbreak_command_wrapper) > (rbreak_command_wrapper, watch_command_wrapper) > (awatch_command_wrapper, rwatch_command_wrapper) > (get_tracepoint_by_number): Constify. > * symtab.c (info_variables_command, rbreak_command) > (symtab_symbol_info): Constify. > (info_variables_command): Add non-const overload. > * top.c (dont_repeat_command): Constify. > * breakpoint.c (ignore_command, commands_command) > (condition_command, tbreak_command, hbreak_command) > (thbreak_command, clear_command, break_command) > (info_breakpoints_command, watch_command, rwatch_command) > (awatch_command, trace_command, ftrace_command, strace_command) > (trace_pass_command, break_range_command, dprintf_command) > (agent_printf_command, get_tracepoint_by_number) > (watch_maybe_just_location, trace_pass_command): Constify. > (info_breakpoints_command): Add non-const overload. > * tracefile.c (tsave_command): Constify. > * infcmd.c (attach_command, disconnect_command, signal_command) > (queue_signal_command, stepi_command, nexti_command) > (finish_command, next_command, step_command, until_command) > (advance_command, jump_command, continue_command, run_command) > (start_command, starti_command, interrupt_command) > (run_command_1, set_inferior_args, step_1): Constify. > * inferior.c (add_inferior_command, remove_inferior_command) > (clone_inferior_command): Constify. > * linux-fork.c (checkpoint_command, restart_command): Constify. > * windows-nat.c (signal_event_command): Constify. > * guile/guile.c (guile_repl_command, guile_command): Constify. > * printcmd.c (x_command, display_command, printf_command) > (output_command, set_command, call_command, print_command) > (eval_command): Constify. > (non_const_set_command): Remove. > (_initialize_printcmd): Update. > * source.c (forward_search_command, reverse_search_command): > Constify. > * jit.c (jit_reader_load_command, jit_reader_unload_command): > Constify. > * infrun.c (handle_command): Constify. > * memattr.c (mem_command): Constify. > * stack.c (return_command, up_command, up_silently_command) > (down_command, down_silently_command, frame_command) > (backtrace_command, func_command, backtrace_command_1): Constify. > (backtrace_command): Add non-const overload. > * remote-sim.c (simulator_command): Constify. > * exec.c (set_section_command): Constify. > * tracepoint.c (tdump_command, trace_variable_command) > (tstatus_command, tstop_command, tstart_command) > (end_actions_pseudocommand, while_stepping_pseudocommand) > (collect_pseudocommand, teval_pseudocommand, actions_command) > (start_tracing, stop_tracing): Constify. > * value.c (init_if_undefined_command): Constify. > * tui/tui-stack.c (tui_update_command): Constify. > * tui/tui-win.c (tui_refresh_all_command) > (tui_set_tab_width_command, tui_set_win_height_command) > (tui_set_focus_command, tui_scroll_forward_command) > (tui_scroll_backward_command, tui_scroll_left_command) > (tui_scroll_right_command, parse_scrolling_args, tui_set_focus) > (tui_set_win_height): Constify. > * tui/tui-layout.c (tui_layout_command): Constify. > * procfs.c (proc_trace_syscalls, proc_trace_sysentry_cmd) > (proc_trace_sysexit_cmd, proc_untrace_sysentry_cmd) > (proc_untrace_sysexit_cmd): Constify. > * remote.c (threadlist_test_cmd, threadinfo_test_cmd) > (threadset_test_cmd, threadlist_update_test_cmd) > (threadalive_test): Constify. > * objc-lang.c (print_object_command): Constify. > * command.h (add_com): Constify. > * cli/cli-dump.c (restore_command): Constify. > * cli/cli-cmds.c (pwd_command, echo_command, quit_command) > (help_command, complete_command, shell_command, edit_command) > (list_command, disassemble_command, make_command) > (apropos_command, alias_command): Constify. > * cli/cli-script.c (document_command, define_command) > (while_command, if_command, validate_comname): Constify. > * cli/cli-decode.c (struct cmd_list_element): Change type of > "fun". > * target.c (do_monitor_command, flash_erase_command): Constify. > * regcache.c (reg_flush_command): Constify. > * reverse.c (reverse_step, reverse_next, reverse_stepi) > (reverse_nexti, reverse_continue, reverse_finish) > (save_bookmark_command, goto_bookmark_command) > (exec_reverse_once): Constify. > * python/python.c (python_interactive_command, python_command): > Constify. > * typeprint.c (ptype_command, whatis_command, whatis_exp): > Constify. > * solib.c (sharedlibrary_command, no_shared_libraries): Constify. > * gcore.c (gcore_command): Constify. Hi Tom, thanks for doing this. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)