From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors
Date: Tue, 03 Oct 2017 11:36:00 -0000 [thread overview]
Message-ID: <86bmlo79an.fsf@gmail.com> (raw)
In-Reply-To: <1506957311-30028-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 2 Oct 2017 16:15:11 +0100")
Pedro Alves <palves@redhat.com> writes:
> @@ -7015,9 +7018,43 @@ Packet: '%s'\n"),
> reason. */
> if (p_temp == p1)
> {
> - struct packet_reg *reg = packet_reg_from_pnum (rsa, pnum);
> + /* If we haven't parsed the event's thread yet, find
> + it now, in order to find the architecture of the
> + reported expedited registers. */
> + if (event->ptid == null_ptid)
> + {
> + const char *thr = strstr (p1 + 1, ";thread:");
> + if (thr != NULL)
> + event->ptid = read_ptid (thr + strlen (";thread:"),
> + NULL);
> + else
> + event->ptid = magic_null_ptid;
> + }
> +
> + if (rsa == NULL)
> + {
> + inferior *inf = (event->ptid == null_ptid
> + ? NULL
> + : find_inferior_ptid (event->ptid));
> + /* If this is the first time we learn anything
> + about this process, skip the registers
> + included in this packet, since we don't yet
> + know which architecture to use to parse
> + them. */
Could you add a comment about when/how does GDB fetch the target
description of the first-time-seen process?
> + if (inf == NULL)
> + {
> + p = strchrnul (p1 + 1, ';');
> + p++;
> + continue;
> + }
Otherwise, patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-10-03 11:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 15:15 [PATCH 0/3] " Pedro Alves
2017-10-02 15:15 ` [PATCH 3/3] " Pedro Alves
2017-10-03 11:36 ` Yao Qi [this message]
2017-10-03 11:40 ` Yao Qi
2017-10-03 12:21 ` Pedro Alves
2017-10-03 14:02 ` Pedro Alves
2017-10-04 10:21 ` Yao Qi
2017-10-04 17:38 ` Pedro Alves
2017-10-05 16:50 ` Ulrich Weigand
2017-10-05 17:08 ` Pedro Alves
2017-12-12 21:33 ` Maciej W. Rozycki
2017-12-13 0:45 ` Pedro Alves
2017-12-13 11:31 ` Maciej W. Rozycki
2017-10-02 15:15 ` [PATCH 1/3] Redesign mock environment for gdbarch selftests Pedro Alves
2017-10-03 11:06 ` Yao Qi
2017-10-03 12:05 ` Pedro Alves
2017-10-04 10:39 ` Yao Qi
2017-10-02 15:15 ` [PATCH 2/3] Reimplement support for "maint print registers" with no running inferior yet Pedro Alves
2017-10-03 11:17 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bmlo79an.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).