From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6817 invoked by alias); 11 Apr 2017 09:16:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6793 invoked by uid 89); 11 Apr 2017 09:16:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f196.google.com Received: from mail-wr0-f196.google.com (HELO mail-wr0-f196.google.com) (209.85.128.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Apr 2017 09:16:24 +0000 Received: by mail-wr0-f196.google.com with SMTP id l44so4842640wrc.2 for ; Tue, 11 Apr 2017 02:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=c2U1laFoqN5Vp8EYudq3/Qi2BegUgeOqTrtzx3tyh6I=; b=Q298GAeNZf58fArqGaUffG+BaBH8wX8h3J24FtzVIeP/lUdZ7bfLHdZANVE/XN32ue ckMPGd7JuuIdCAzGxd+R8Uivy6thKInRdHWtdpB1bzhSadqc80IqD4G5CTfwkmQLIAtC ziAkfvfdK9+nMkDJTruTz7biAGPiHS/jsZlK631ba45kyguFqfFCcz0uiVo3LCsAYJOY 3lBjgjBcRsYZeBznhmDjqtCExwSlR37zgFZer3vrDw/2fTVe/RtKBPhMePXdy3mto08E 4A4zCPD9CcnEgEYSkDDYxLFuLLy/01PV8Wi5rKYx9dOWD+oEa9RYDpbETDA1oPj/59jo 8yrg== X-Gm-Message-State: AFeK/H3o8B6XoRltkHaBaqRrGp5AdglAWCKqhaUwpUSLFRKLDyTyot6cYuPaOl5rGLm3dw== X-Received: by 10.223.135.134 with SMTP id b6mr24600162wrb.48.1491902184041; Tue, 11 Apr 2017 02:16:24 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id b66sm20785478wrd.29.2017.04.11.02.16.22 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 11 Apr 2017 02:16:23 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 6/11] Add ALPHA_MAX_REGISTER_SIZE References: <772F5764-0F2A-4F53-BC41-C36AF15BED21@arm.com> Date: Tue, 11 Apr 2017 09:16:00 -0000 In-Reply-To: <772F5764-0F2A-4F53-BC41-C36AF15BED21@arm.com> (Alan Hayward's message of "Tue, 4 Apr 2017 10:14:08 +0000") Message-ID: <86bms3wbh5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00261.txt.bz2 Alan Hayward writes: > diff --git a/gdb/alpha-tdep.h b/gdb/alpha-tdep.h > index ab46ba56bef1ffb1cea541c506ffed6a5ae9b556..316d94d0bb53e9bc7943d406b= f81f7d597437ff3 100644 > --- a/gdb/alpha-tdep.h > +++ b/gdb/alpha-tdep.h > @@ -26,6 +26,9 @@ struct regcache; > real way to know how big a register is. */ > #define ALPHA_REGISTER_SIZE 8 > > +/* Big enough to hold the size of the largest register in bytes. */ > +#define ALPHA_MAX_REGISTER_SIZE 8 > + > --- a/gdb/alpha-tdep.c > +++ b/gdb/alpha-tdep.c > @@ -244,7 +244,7 @@ alpha_register_to_value (struct frame_info *frame, in= t regnum, > int *optimizedp, int *unavailablep) > { > struct gdbarch *gdbarch =3D get_frame_arch (frame); > - gdb_byte in[MAX_REGISTER_SIZE]; > + gdb_byte in[ALPHA_MAX_REGISTER_SIZE]; > > /* Convert to TYPE. */ > if (!get_frame_register_bytes (frame, regnum, 0, We can use get_frame_register_value, so "in" can be removed. > @@ -266,7 +266,7 @@ static void > alpha_value_to_register (struct frame_info *frame, int regnum, > struct type *valtype, const gdb_byte *in) > { > - gdb_byte out[MAX_REGISTER_SIZE]; > + gdb_byte out[ALPHA_MAX_REGISTER_SIZE]; Why don't you use ALPHA_REGISTER_SIZE? --=20 Yao (=E9=BD=90=E5=B0=A7)