From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37331 invoked by alias); 27 May 2015 08:21:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37320 invoked by uid 89); 27 May 2015 08:21:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f172.google.com Received: from mail-pd0-f172.google.com (HELO mail-pd0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 08:21:54 +0000 Received: by pdbqa5 with SMTP id qa5so4768591pdb.0 for ; Wed, 27 May 2015 01:21:52 -0700 (PDT) X-Received: by 10.70.88.170 with SMTP id bh10mr56850788pdb.62.1432714912769; Wed, 27 May 2015 01:21:52 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id de4sm15323026pbb.95.2015.05.27.01.21.50 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 01:21:51 -0700 (PDT) From: Yao Qi To: Edjunior Barbosa Machado Cc: Yao Qi , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support References: <1432041752-4638-1-git-send-email-yao.qi@linaro.org> <1432041752-4638-3-git-send-email-yao.qi@linaro.org> <555E3EAE.2080107@redhat.com> <86h9qzr2g2.fsf@gmail.com> <5564D0E9.3000402@linux.vnet.ibm.com> Date: Wed, 27 May 2015 08:21:00 -0000 In-Reply-To: <5564D0E9.3000402@linux.vnet.ibm.com> (Edjunior Barbosa Machado's message of "Tue, 26 May 2015 17:00:41 -0300") Message-ID: <86d21mqvl0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00648.txt.bz2 Edjunior Barbosa Machado writes: > noticed this commit (99afc8) introduced this issue when checking for unin= itialized vars: > Sorry for breaking the build. > gcc -g -O2 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/= config -DLOCALEDIR=3D"\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../= gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. = -I../../gdb/../zlib -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I..= /libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuil= d-gnulib/import -DTUI=3D1 -I/usr/include/python2.7 -I/usr/include/python= 2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno= -switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototyp= es -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-decla= ration -Wold-style-definition -Wformat-nonliteral -Werror -c -o aarch64-tde= p.o -MT aarch64-tdep.o -MMD -MP -MF .deps/aarch64-tdep.Tpo ../../gdb/aarch6= 4-tdep.c > ../../gdb/aarch64-tdep.c: In function =E2=80=98aarch64_process_record=E2= =80=99: > ../../gdb/aarch64-tdep.c:2823:23: error: =E2=80=98record_buf[0]=E2=80=99 = may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] > memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH= ); \ > ^ > ../../gdb/aarch64-tdep.c:3529:12: note: =E2=80=98record_buf[0]=E2=80=99 w= as declared here > uint32_t record_buf[2]; > ^ > > The simple patch below intends to fix this. Ok? This build error reveals some logic error inside function aarch64_record_data_proc_simd_fp on decoding instructions. I'll take a loo= k. What is your gcc version? I use gcc-4.9 and gcc-5, but unable to reproduce this compilation error. --=20 Yao (=E9=BD=90=E5=B0=A7)