From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050:0:465::103]) by sourceware.org (Postfix) with ESMTPS id D62273858C78; Thu, 10 Aug 2023 19:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D62273858C78 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4RMGXM2fyLz9sRx; Thu, 10 Aug 2023 21:02:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1691694179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rz5lRakn9ca7zaLSXKzQ56M+di4YFPipN2fgv/OB+2s=; b=e+9e9oe6/5w7SbvnOc8464QE5ZLP8XcAMSn4afJ098zEG4+d0UzZNrRPDBh3Wj/ASbQ6ZN 9+ScASy7eFPQYsgbruXsfn3brFz78JeNAaj7i+2irzFPo5VWCaqmNHNdS0SK6a1/oKxfPC 9VUaIJEQZz2DnECQ6YGbUW4oVlAMdvk7IvqYzu9SVZnPaN7uf3ns3MsM74YmSJrKTyFsVN fMJ+q8t7mq8TxeIGqXpqMb603rw991A7mp62KR3DAk3Z/ZT9FBGAoHpXyUjsNrWlWSMVZl tl2ttufsfY5ErxZsfoZTSBIVX3AaXfTX9Kt2kzK1751A6PQ0mmwrMk1WT4D4Lg== References: <1668107159-16961-1-git-send-email-apinski@marvell.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: Matthias Klose Cc: apinski@marvell.com, gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb Date: Thu, 10 Aug 2023 21:00:55 +0200 In-reply-to: Message-ID: <86edkahg9r.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 4RMGXM2fyLz9sRx X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Matthias Klose via Gcc-patches writes: > On 10.11.22 20:05, apinski--- via Binutils wrote: >> From: Andrew Pinski >> This patch uses the toplevel configure parts for GMP/MPFR for >> gdb. The only thing is that gdb now requires MPFR for building. >> Before it was a recommended but not required library. >> Also this allows building of GMP and MPFR with the toplevel >> directory just like how it is done for GCC. >> We now error out in the toplevel configure of the version >> of GMP and MPFR that is wrong. >> OK after GDB 13 branches? Build gdb 3 ways: >> with GMP and MPFR in the toplevel (static library used at that point for= both) >> With only MPFR in the toplevel (GMP distro library used and MPFR built f= rom source) >> With neither GMP and MPFR in the toplevel (distro libraries used) > > this still seems to be broken for a gdb trunk build, using GMP and MPFR s= ystem > libraries: > > linking gdb: > > [...] > ../gnulib/import/libgnu.a -Lyes/lib -lmpfr -lgmp -lsource-highlight > -lboost_regex -lxxhash -ldebuginfod -ldl > -Wl,--dynamic-list=3D/<>/gdb/proc-service.list > ./libtool: line 5209: cd: yes/lib: No such file or directory > libtool: link: cannot determine absolute directory name of `yes/lib' > make[3]: *** [Makefile:2174: gdb] Error 1 > make[3]: Leaving directory '/<>/build/default/gdb' > > full build log at > https://launchpad.net/~doko/+archive/ubuntu/toolchain/+sourcepub/15065515= /+listing-archive-extra > > > the toplevel config.log has: > > configure:8183: checking for the correct version of gmp.h > configure:8202: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c = >&5 > configure:8202: $? =3D 0 > configure:8220: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c = >&5 > configure:8220: $? =3D 0 > configure:8221: result: yes > configure:8237: checking for the correct version of mpfr.h > configure:8255: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c = >&5 > configure:8255: $? =3D 0 > configure:8272: x86_64-linux-gnu-gcc -c -Iyes/include -fPIC conftest.c = >&5 > configure:8272: $? =3D 0 > configure:8273: result: yes > configure:8342: checking for the correct version of the gmp/mpfr libraries > configure:8366: x86_64-linux-gnu-gcc -o conftest -Iyes/include -fPIC > conftest.c -Lyes/lib -lmpfr -lgmp >&5 > configure:8366: $? =3D 0 > configure:8367: result: yes > configure:8615: checking for isl 0.15 or later > configure:8628: x86_64-linux-gnu-gcc -o conftest -Iyes/include -fPIC = -lisl > -Lyes/lib -lmpfr -lgmp conftest.c -lisl -lgmp >&5 > configure:8628: $? =3D 0 Seems that you're passing simply --with-mpfr, however: AC_ARG_WITH(mpfr, [AS_HELP_STRING([--with-mpfr=3DPATH], [specify prefix directory for installed MPFR package. Equivalent to --with-mpfr-include=3DPATH/include plus --with-mpfr-lib=3DPATH/lib])]) ... so it is interpreted to mean that the prefix MPFR is installed in is yes/include (perhaps we should warn for the 'yes' case - that'd be less confusing). I think you should be able to get away without passing =2D-with-mpfr at all if your toolchain has mpfr available (and there's no mpfr in the toplevel, to inhibit the toplevel trying to build its own copy). Hope that helps, have a lovely night. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZNU0YF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTxUEBAJCzrSyG18JG/v1dw+H/wkDokFleVV3sm95L /07YizNSAP42/OS7rsmTA64nBLcftVDM5SKZsy5bvSs5CU7In2cRBQ== =tonv -----END PGP SIGNATURE----- --=-=-=--