From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2062 invoked by alias); 23 Feb 2016 08:51:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2034 invoked by uid 89); 23 Feb 2016 08:51:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1014, ended, HX-Received:Tue X-HELO: mail-pf0-f170.google.com Received: from mail-pf0-f170.google.com (HELO mail-pf0-f170.google.com) (209.85.192.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 23 Feb 2016 08:51:48 +0000 Received: by mail-pf0-f170.google.com with SMTP id q63so108678046pfb.0 for ; Tue, 23 Feb 2016 00:51:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=r2PVZGOkOpiEMYvTCUOEJzQQMFGpyypvSmIgoweIoYo=; b=GtGVU7RVJ/4U5VuiCpKX6qsdgPusBUkp6udrLB66/IU+/0E8tvYJf7f1Mqa05Pl9sZ knDsNlAM4zocKwb8L8X44gEaz8edvpR0v5UcuM0jaBaiOlWgKm7fO0sThTr8gEpkPaju iHay4zqMiLg5hCNh3Pb+ZqVC453FVwevJwbjy5SRE4L/BWytteWopuyMvEo26HtaBcoE ZVSuVAOViHwW/nG02WHAsyPEBlntpfuJ92bGZDWnTNn9HMhC2bNQQTP7etXPDy1u0Phs VhxZd07WddRzNrfXwMM8jLdZ0CIt+bW9pw3vJ1vU/QXKaUAtw6j3W35z54CCYC6IFaWD XszQ== X-Gm-Message-State: AG10YOQR1gqGLDPETQN+hpmdVIjLz053JJKepdnFU6hxHD1gvTljzUXc397ZD+A1E0x92g== X-Received: by 10.98.16.86 with SMTP id y83mr44221314pfi.45.1456217506582; Tue, 23 Feb 2016 00:51:46 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id q16sm42204448pfi.80.2016.02.23.00.51.44 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 23 Feb 2016 00:51:45 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/10] Command line input handling TLC References: <1455817236-13642-1-git-send-email-palves@redhat.com> Date: Tue, 23 Feb 2016 08:51:00 -0000 In-Reply-To: <1455817236-13642-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Thu, 18 Feb 2016 17:40:26 +0000") Message-ID: <86egc3dd2d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00679.txt.bz2 Pedro Alves writes: > I looked a bit at changing immediate_quit users in order to get rid of > throws from signal handlers, for the C++ conversion, and ended up > stumbling on gdb's input code... > > So today I split this patch: > > [PATCH 02/23] Command line input handling TLC > https://sourceware.org/ml/gdb-patches/2016-02/msg00070.html > > into smaller pieces. I think this can go in independently of the rest > of that series. Thanks for splitting patches... > > The original motivation here was factor out all the globals used by > the command line input handling code to a structure, so that we can > keep multiple instances of that later on. But, I found that this code > is a lot more messier than it needs to be, thus this series cleans > things up significantly in the process as well. > > I tried to split the last patch further into smaller independent > pieces, but failed... These patches look good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)