From: Yao Qi <qiyaoltc@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 7/8] Add truncate_repeat_arguments function
Date: Mon, 16 Oct 2017 09:53:00 -0000 [thread overview]
Message-ID: <86fuajwh8w.fsf@gmail.com> (raw)
In-Reply-To: <87h8uzu6xw.fsf@tromey.com> (Tom Tromey's message of "Sun, 15 Oct 2017 21:07:07 -0600")
Tom Tromey <tom@tromey.com> writes:
> +/* If not NULL, the arguments that should be passed if the current
> + command is repeated. */
> +
> +static const char *repeat_arguments;
> +
> +/* See command.h. */
> +
> +void
> +set_repeat_arguments (const char *args)
> +{
> + repeat_arguments = args;
> +}
This global variable worries me a little bit. Is it possible that
different part of GDB request to execute the repeatable commands? For
example, CLI and MI issues command, or different UIs issue command.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-10-16 9:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 21:00 [RFA 0/8] Constify many commands Tom Tromey
2017-10-13 21:00 ` [RFA 1/8] Constify add_abbrev_prefix_cmd Tom Tromey
2017-10-16 9:02 ` Yao Qi
2017-10-16 15:54 ` Tom Tromey
2017-10-16 20:23 ` Yao Qi
2017-10-13 21:00 ` [RFA 6/8] Remove cleanup from backtrace_command Tom Tromey
2017-10-16 9:46 ` Yao Qi
2017-10-13 21:00 ` [RFA 2/8] Constify add_com_suppress_notification Tom Tromey
2017-10-16 9:03 ` Yao Qi
2017-10-16 15:55 ` Tom Tromey
2017-10-13 21:00 ` [RFA 8/8] Constify add_com Tom Tromey
2017-10-16 9:59 ` Yao Qi
2017-10-13 21:00 ` [RFA 3/8] Make set_cmd_cfunc private Tom Tromey
2017-10-16 9:20 ` Yao Qi
2017-10-13 21:00 ` [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr Tom Tromey
2017-10-16 9:33 ` Yao Qi
2017-10-16 18:37 ` Simon Marchi
2017-10-17 11:05 ` Yao Qi
2017-10-18 3:32 ` Tom Tromey
2017-10-18 9:37 ` Pedro Alves
2017-11-06 16:33 ` Tom Tromey
2017-10-13 21:00 ` [RFA 5/8] Constify add_path and friends Tom Tromey
2017-10-16 9:35 ` Yao Qi
2017-10-13 21:00 ` [RFA 7/8] Add truncate_repeat_arguments function Tom Tromey
2017-10-14 4:49 ` Tom Tromey
2017-10-16 3:07 ` Tom Tromey
2017-10-16 9:53 ` Yao Qi [this message]
2017-10-18 3:48 ` Tom Tromey
2017-11-06 16:38 ` Tom Tromey
2017-11-07 14:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fuajwh8w.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).