From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100415 invoked by alias); 12 May 2016 12:06:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100394 invoked by uid 89); 12 May 2016 12:06:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.98.102.20 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 12 May 2016 12:06:19 +0000 Received: by mail-pf0-f193.google.com with SMTP id 145so6282612pfz.1 for ; Thu, 12 May 2016 05:06:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+m/i/rR4jtiPaZWmgWEPSDwTIgEf4sDpRP45onnv3tg=; b=hsvxCENKoN3vKgDvSs3APKYjedgTLx2DT1VMlKDQOqbIKGw4IYOgTG6TDxQyJ7ZhB4 AQdi6jdY8Ekb5BPkpuUy6mFoSoGZiD0yWahvwbXlNUrhzwUwV2u/W9VKVsWGIvewkEB3 4p8yeCIMDIAbIUH+FkZQCTh9gx+W/VPwaar4VztTWUzjz2rGrzgOV9Ef1ijO4+oibfGs fthrb7FX0k2WH4QfH24jqFQ8hPYbVKO28//HTyDYWwdOYNyCo7npTVgyEWwm+nqYz5OT rStfQwX7JPkxYdZia2MQ3b9qS+LlzxHwYvPyW6S18iHRj+DZSJUWjq86bY7UXZ5QT0vv sOxw== X-Gm-Message-State: AOPr4FWiz3zeueScV+e6AsuegpmDMIEa9LZzDBNQkbrQ51qomxlZLM9noIYvyu5Dw8e0qg== X-Received: by 10.98.102.20 with SMTP id a20mr13253902pfc.137.1463054778038; Thu, 12 May 2016 05:06:18 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id g5sm19524184pac.1.2016.05.12.05.06.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 12 May 2016 05:06:17 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Fortran, typeprint: Take level of details into account when printing elements of a structure. References: <1462889739-30359-1-git-send-email-bernhard.heckel@intel.com> <1462889739-30359-3-git-send-email-bernhard.heckel@intel.com> Date: Thu, 12 May 2016 12:06:00 -0000 In-Reply-To: <1462889739-30359-3-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Tue, 10 May 2016 16:15:37 +0200") Message-ID: <86futncwgb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00191.txt.bz2 Bernhard Heckel writes: > - f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show, > - level + 4); > - fputs_filtered (" :: ", stream); > - fputs_filtered (TYPE_FIELD_NAME (type, index), stream); > - f_type_print_varspec_suffix (TYPE_FIELD_TYPE (type, index), > - stream, 0, 0, 0, 0); > fputs_filtered ("\n", stream); > - }=20 > - fprintfi_filtered (level, stream, "End Type "); > - fputs_filtered (TYPE_TAG_NAME (type), stream); > + for (index =3D 0; index < TYPE_NFIELDS (type); index++) > + { > + f_type_print_base (TYPE_FIELD_TYPE (type, index), stream, show - = 1, > + level + 4); I read this patch again, and happen to see that we pass "show - 1" to f_type_print_base instead of "show". I think the change is correct, but it shouldn't fall in this patch, right? --=20 Yao (=E9=BD=90=E5=B0=A7)