From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11257 invoked by alias); 24 Jul 2015 09:33:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11234 invoked by uid 89); 24 Jul 2015 09:33:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 24 Jul 2015 09:33:58 +0000 Received: by pabkd10 with SMTP id kd10so11765118pab.2 for ; Fri, 24 Jul 2015 02:33:56 -0700 (PDT) X-Received: by 10.70.7.162 with SMTP id k2mr28870365pda.128.1437730436331; Fri, 24 Jul 2015 02:33:56 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ti10sm13528404pab.20.2015.07.24.02.33.53 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Fri, 24 Jul 2015 02:33:55 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] Set general_thread after restart References: <1437392126-29503-1-git-send-email-yao.qi@linaro.org> <1437392126-29503-4-git-send-email-yao.qi@linaro.org> <55B1718B.10100@redhat.com> Date: Fri, 24 Jul 2015 09:33:00 -0000 In-Reply-To: <55B1718B.10100@redhat.com> (Pedro Alves's message of "Thu, 23 Jul 2015 23:58:19 +0100") Message-ID: <86fv4dhpc2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00684.txt.bz2 Pedro Alves writes: > I think this should be: > > if (last_status.kind =3D=3D TARGET_WAITKIND_STOPPED) > { > /* Stopped at the first instruction of the target process. */ > general_thread =3D last_ptid; > } > else > { > /* Something went wrong. */ > general_thread =3D null_ptid; > } > OK, I'll fix it in the commit ready to push. >> +# Test running programs using extended-remote. > > Comment looks stale. Looks like I missed pointing out the same > in patch #2. > I'll remove it. > Otherwise looks good to me. > > (I think it's likely we have lots of stale-data bugs on the > gdb side after R, as we don't resync much. It previously crossed my mind > that immediately after sending R, gdb should refresh all its > remote state anew, like if it had just disconnected and then reconnected. > That is, do most of what remote_start_remote does, except the > connection-specific details (qSupported, etc.) > Hard to justify the effort though -- I don't think I ever worked with > a stub that relies on R.) Even GDB refreshes all its state after sending R packet, we still need some way to test GDB and GDBserver with R packet used. Otherwise, it will be bit-rotten in the future. GDBserver has already had an option --disable-packet, so that we can extend it to force GDBserver/GDB use R packet. However, I don't think we use --disable-packet much in our testing, at least I don't. Probably we can hack native-gdbserver.exp to run tests in a loop and pass different --disable-packet=3DFOO to GDBserver in each iteration. --=20 Yao (=E9=BD=90=E5=B0=A7)