From: Yao Qi <qiyaoltc@gmail.com>
To: Kyle Huey <me@kylehuey.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Do arm_abi detection for ELFOSABI_GNU binaries
Date: Tue, 19 May 2015 09:41:00 -0000 [thread overview]
Message-ID: <86fv6ssy3v.fsf@gmail.com> (raw)
In-Reply-To: <CAP045ApZ9xcDwDk45CXcd=0gxhqsTcUcJ9jAER4RkRn1RCs_Vg@mail.gmail.com> (Kyle Huey's message of "Fri, 8 May 2015 10:11:41 -0700")
Kyle Huey <me@kylehuey.com> writes:
> Thank you for the tip. Have you had a chance to look at the patch?
Hi Kyle,
Sorry for the delayed reply. I spent some hours investigating how this
patch break some cases, but can't find any one. I also take a look at
code in binutils, and find the code pattern
"e_ident[EI_OSABI] == ELFOSABI_GNU || e_ident[EI_OSABI] == ELFOSABI_NONE"
is used here and there.
This patch is OK to commit. If you don't have a sourceware account to
push your commit in, I can do it for you. Your patch is just one line,
so it can be pushed in as a "tiny patch".
--
Yao (齐尧)
next prev parent reply other threads:[~2015-05-19 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 20:55 Kyle Huey
2015-04-16 17:15 ` Kyle Huey
2015-04-17 8:41 ` Yao Qi
2015-05-08 17:12 ` Kyle Huey
2015-05-19 9:41 ` Yao Qi [this message]
2015-05-19 14:04 ` Kyle Huey
2015-05-28 8:19 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fv6ssy3v.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=me@kylehuey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).