From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91016 invoked by alias); 3 Apr 2017 12:41:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90986 invoked by uid 89); 3 Apr 2017 12:41:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=We'll, HX-HELO:sk:mail-lf X-HELO: mail-lf0-f42.google.com Received: from mail-lf0-f42.google.com (HELO mail-lf0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Apr 2017 12:41:29 +0000 Received: by mail-lf0-f42.google.com with SMTP id h125so72279388lfe.0 for ; Mon, 03 Apr 2017 05:41:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=96Q7Twg00oqfvfkqu47zgILcv6uu5gjileXjijVpBlg=; b=h2hW7Gm/B9ip+2S1LkdxPCc7fahPyo8L5Qi8x1Jl8mdDbTBmptA0/NAUN9pzPCzv1S AmAgPjUoZgZAFxgKVS3sYS2ifXPd/5FkrWIbjIzNEG3COpQxZhsEn29srlnzmeL6FaBm mLqRNoY4qUKlUY1AFx8+d/+CT709IYmcIldVg0iBK5jYLtmapO4PWDKM8n39JYvH1qPS VLlfxo6zbe9njHksPkTYhFyIjbr1IV4ZZoNePqvwKLVmKDD2hLZzrQDmhdhGGhbhf5bf 7YpGgj9p+WeJSPRRIOPakPEXYGU9tVtm8kLPOfWi0k9mNLTwnmS+ubg6YmmXQS0u8udn JjqQ== X-Gm-Message-State: AFeK/H24OmRq9EYISLir/JzLGdzYl3axYd0jfUYKdYHf7ixQKziz5biMp26/bIIUzoQPWg== X-Received: by 10.28.153.149 with SMTP id b143mr9789884wme.87.1491223288875; Mon, 03 Apr 2017 05:41:28 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 127sm14211492wmt.20.2017.04.03.05.41.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 03 Apr 2017 05:41:28 -0700 (PDT) From: Yao Qi To: Antoine Tremblay Cc: Pedro Alves , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 1/2] This patch fixes GDBServer's run control for single stepping References: <20161129120702.9490-1-antoine.tremblay@ericsson.com> <20170127150139.GB24676@E107787-LIN> <2255ed6f-a146-026c-f871-00e9a33dfcf0@redhat.com> <86d1cy4umo.fsf@gmail.com> <86d1cxwgpk.fsf@gmail.com> Date: Mon, 03 Apr 2017 12:41:00 -0000 In-Reply-To: (Antoine Tremblay's message of "Fri, 31 Mar 2017 14:22:10 -0400") Message-ID: <86h925ll3f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00000.txt.bz2 Antoine Tremblay writes: > I think maybe the best solution would be to abstract only that part of > get_next_pc in a function: the if block starting with if > (self->has_thumb2_breakpoint) around line 301. > > And have only that part return the next_pc + the breakpoint kind, this > would avoid breaking all the virtual get_next_pc functions just for that > case and allow the same code to be used in kind_from_current_state. > > We'll still redo the work but at least the code will be in one > place. WDYT ? That should be fine, although I am not exactly sure what are you going to do. --=20 Yao (=E9=BD=90=E5=B0=A7)