Re: [PATCH 2/2] gdbserver, remote: introduce "id_str" in the "qXfer:threads:read" XML

[Eli Zaretskii <eliz@gnu.org>]

> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Date: Tue,  2 Apr 2024 12:20:20 +0200
> 
> GDB prints the target id of a thread in various places such as the
> output of the "info threads" command in the "Target Id" column or when
> switching to a thread.  A target can define what to print for a given
> ptid by overriding the `pid_to_str` method.
> 
> The remote target is a gateway behind which one of many various
> targets could be running.  The remote target converts a given ptid to
> a string in a uniform way, without consulting the low target at the
> server-side.
> 
> In this patch we introduce a new attribute in the XML that is sent in
> response to the "qXfer:threads:read" RSP packet, so that a low target
> at the server side, if it wishes, can specify what to print as the
> target id of a thread.
> 
> Note that the existing "name" attribute or the "extra" text provided
> in the XML are not sufficient for the server-side low target to
> achieve the goal.  Those attributes, when present, are simply appended
> to the target id by GDB.
> ---
>  gdb/NEWS            |  9 +++++++++
>  gdb/doc/gdb.texinfo |  7 +++++--
>  gdb/remote.c        | 26 +++++++++++++++++++++++++-
>  gdbserver/server.cc |  4 ++++
>  gdbserver/target.cc |  6 ++++++
>  gdbserver/target.h  | 13 +++++++++++++
>  6 files changed, 62 insertions(+), 3 deletions(-)

Thanks, the documentation parts are OK, with the following minor nit:

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -48081,7 +48081,7 @@ the following structure:
>  @smallexample
>  <?xml version="1.0"?>
>  <threads>
> -    <thread id="id" core="0" name="name" handle="XX...">
> +    <thread id="id" core="0" name="name" id_str="..." handle="XX...">
>      ... description ...
>      </thread>
>  </threads>

Please replace the ellipsis with an example of a real-life value.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>