From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95817 invoked by alias); 15 Feb 2016 09:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95801 invoked by uid 89); 15 Feb 2016 09:12:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Feb 2016 09:12:27 +0000 Received: by mail-pf0-f195.google.com with SMTP id c10so7271108pfc.0 for ; Mon, 15 Feb 2016 01:12:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=91O0CsTQ9gINJfUIMmPYcmjuR+X+jPfuwhX3Ivncif0=; b=dBYKBI5kk9X96G1cgge2/qSKD+8kMmZXUENi/CdWvsnC+SAJYUemPkn1gt38PyR9Wf /uER73HFOXP3w4cfUrnlsSJwdkZnxdbIUigngbpoKQFDS6J4JyGU8JAfFrzEC0Ir+Nrb Jdi6Cpl1EUHRCCuagVFAy1sdMDG9P9oSuCgJFPYGTYAqe03veBlOBztwd5sJXukXzZXL S6J/2lj1fWZuzGUK01R24/7G15H4Eq0DNLlFVKfq8sKqhvkkpnnksSHRFIJp2qG6+A7i Jom05MApsrL22h+EHoRSn24tAr+26IPDF+5waR9ADJdYTgzjtikF0h4UhugCa1J69NIL lsdA== X-Gm-Message-State: AG10YORd40NI93JZ/b8/Y9mY4+lAHoGysSM0rZt70mkOOrb6NBg7pNo7v1R45k/LueHqKQ== X-Received: by 10.98.31.21 with SMTP id f21mr21623562pff.134.1455527546278; Mon, 15 Feb 2016 01:12:26 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id d8sm36924259pas.14.2016.02.15.01.12.24 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 15 Feb 2016 01:12:25 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Plumb enum remove_bp_reason all the way to target_remove_breakpoint References: <1455475070-17797-1-git-send-email-palves@redhat.com> <1455475070-17797-4-git-send-email-palves@redhat.com> Date: Mon, 15 Feb 2016 09:12:00 -0000 In-Reply-To: <1455475070-17797-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Sun, 14 Feb 2016 18:37:49 +0000") Message-ID: <86io1qe3rd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00454.txt.bz2 Pedro Alves writes: Hi Pedro, > So the target knows whether we're detaching breakpoints. > Nothing uses the parameter in this patch yet. > > gdb/ChangeLog: > 2016-02-14 Pedro Alves > > * break-catch-sig.c (signal_catchpoint_remove_location): Adjust > interface. > * break-catch-syscall.c (remove_catch_syscall): > * breakpoint.c (enum remove_bp_reason): Moved to breakpoint.h. > (remove_breakpoint_1): Pass 'reason' down. > (remove_catch_fork, remove_catch_vfork, remove_catch_solib) > (remove_catch_exec, remove_watchpoint, remove_masked_watchpoint) > (base_breakpoint_remove_location, bkpt_remove_location) > (bkpt_probe_remove_location, bkpt_probe_remove_location): Adjust > interface. > * breakpoint.h (enum remove_bp_reason): Moved here from > breakpoint.c. > (struct breakpoint_ops) : Add 'reason' parameter. > * corelow.c (core_remove_breakpoint): New function. > (init_core_ops): Install it as to_remove_breakpoint method. > * exec.c (exec_remove_breakpoint): New function. > (init_exec_ops): Install it as to_remove_breakpoint method. > * mem-break.c (memory_remove_breakpoint): Adjust interface. > * record-btrace.c (record_btrace_remove_breakpoint): Adjust > interface. > * record-full.c (record_full_remove_breakpoint) > (record_full_core_remove_breakpoint): Adjust interface. > * remote.c (remote_remove_breakpoint): Adjust interface. > * target-debug.h (target_debug_print_enum_remove_bp_reason): New > macro. > * target-delegates.c: Regenerate. > * target.c (target_remove_breakpoint): Add 'reason' parameter. > * target.h (struct target_ops) : Add > 'reason' parameter. > (target_remove_breakpoint, memory_remove_breakpoint): Add 'reason' > parameter. We also need to add 'reason' in m32r_remove_breakpoint, mips_remove_breakpoint and procfs_remove_breakpoint, otherwise the patch breaks the all-targets build. This patch series look good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)