From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54044 invoked by alias); 11 Mar 2015 11:32:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54032 invoked by uid 89); 11 Mar 2015 11:32:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 11 Mar 2015 11:32:10 +0000 Received: by pabrd3 with SMTP id rd3so10745538pab.6 for ; Wed, 11 Mar 2015 04:32:08 -0700 (PDT) X-Received: by 10.66.153.1 with SMTP id vc1mr76922529pab.109.1426073527888; Wed, 11 Mar 2015 04:32:07 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id z6sm3006141pdm.78.2015.03.11.04.32.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 11 Mar 2015 04:32:07 -0700 (PDT) From: Yao Qi To: Sergio Durigan Junior Cc: GDB Patches Subject: Re: [PATCH 2/2] Create gdb/break-catch-syscall.c References: <1426030105-15485-1-git-send-email-sergiodj@redhat.com> <1426030105-15485-3-git-send-email-sergiodj@redhat.com> Date: Wed, 11 Mar 2015 11:32:00 -0000 In-Reply-To: <1426030105-15485-3-git-send-email-sergiodj@redhat.com> (Sergio Durigan Junior's message of "Tue, 10 Mar 2015 19:28:25 -0400") Message-ID: <86ioe7hirx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00278.txt.bz2 Sergio Durigan Junior writes: Hi Sergio, Thanks for doing this. > Tested by running the 'gdb.base/catch-syscall.exp' testcase. > Could you please run the whole testsuite? it shouldn't take much time. If it is regression free, the patch is fine by me, with the following typo fixed, > gdb/ChangeLog: > 2015-03-10 Sergio Durigan Junior > > * Makefile.in (SFILES): New object break-catch-syscall.o. It should be break-catch-syscall.c > (COMMON_OBS): Likewise. > * break-catch-syscall.c: New file. > * breakpoint.c: Remove inclusion of "xml-syscall.h". > (syscall_catchpoint_p): Move declaration to break-catch-syscall.c > (struct syscall_catchpoint): Likewise. > (dtor_catch_syscall): Likewise. > (catch_syscall_inferior_data): Likewise. > (struct catch_syscall_inferior_data): Likewise. > (get_catch_syscall_inferior_data): Likewise. > (catch_syscall_inferior_data_cleanup): Likewise. > (insert_catch_syscall): Likewise. > (remove_catch_syscall): Likewise. > (breakpoint_hit_catch_syscall): Likewise. > (print_it_catch_syscall): Likewise. > (print_one_catch_syscall): Likewise. > (print_mention_catch_syscall): Likewise. > (print_recreate_catch_syscall): Likewise. > (catch_syscall_breakpoint_ops): Likewise. > (syscall_catchpoint_p): Likewise. > (create_syscall_event_catchpoint): Likewise. > (catch_syscall_split_args): Likewise. > (catch_syscall_command_1): Likewise. > (is_syscall_catchpoint_enabled): Likewise. > (catch_syscall_enabled): Likewise. > (catching_syscall_number): Likewise. > (catch_syscall_completer): Likewise. > (clear_syscall_counts): Likewise. > (initialize_breakpoint_ops): Move initialization of syscall > catchpoints to break-catch-syscall.c. > (_initialize_breakpoint): Move code related to syscall catchpoints > to break-catch-syscall.c. > --- > gdb/Makefile.in | 2 + > gdb/break-catch-syscall.c | 659 ++++++++++++++++++++++++++++++++++++++++= ++++++ > gdb/breakpoint.c | 600 ----------------------------------------- > 3 files changed, 661 insertions(+), 600 deletions(-) > create mode 100644 gdb/break-catch-syscall.c > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 8c2a4de..f59ad66 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -816,6 +816,7 @@ SFILES =3D ada-exp.y ada-lang.c ada-typeprint.c ada-v= alprint.c ada-tasks.c \ > bfd-target.c \ > block.c blockframe.c \ > breakpoint.c break-catch-sig.c break-catch-throw.c \ > + break-catch-syscall.o \ Likewise. > build-id.c buildsym.c \ > c-exp.y c-lang.c c-typeprint.c c-valprint.c c-varobj.c \ > charset.c common/cleanups.c cli-out.c coffread.c coff-pe-read.c \ --=20 Yao (=E9=BD=90=E5=B0=A7)