From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Add test for fast tracepoint enable/disable
Date: Thu, 31 Mar 2016 10:58:00 -0000 [thread overview]
Message-ID: <86k2kirk18.fsf@gmail.com> (raw)
In-Reply-To: <1459351018-23718-2-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 30 Mar 2016 11:16:58 -0400")
Simon Marchi <simon.marchi@ericsson.com> writes:
> +# Check that the target supports trace.
> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
> + untested "Couldn't compile test program"
> + return -1
> +}
Why do you compile program with pthread?
> +
> +clean_restart ${testfile}
> +
> +if ![runto_main] {
> + fail "Can't run to main to check for trace support"
> + return -1
> +}
> +
> +if ![gdb_target_supports_trace] {
> + unsupported "target does not support trace"
> + return -1
> +}
> +
> +# Compile the test case with the in-process agent library.
> +set libipa [get_in_proc_agent]
> +gdb_load_shlibs $libipa
> +
> +lappend options shlib=$libipa
> +
> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
> + untested "Couldn't compile test program with in-process agent library"
> + return -1
> +}
Likewise.
> +
> +# This test makes sure that disabling and enabling fast tracepoints works
> +# correctly.
> +
> +proc test_ftrace_enable_disable { } {
Can you extend the test to cover normal tracepoint as well? It
shouldn't be hard. You can just pass argument "type" to "proc
test_trace_enable_disable" like,
proc test_trace_enable_disable { type } {
and the type can be "trace" and "ftrace".
--
Yao (齐尧)
next prev parent reply other threads:[~2016-03-31 10:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:17 [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag Simon Marchi
2016-03-30 15:17 ` [PATCH 2/2] Add test for fast tracepoint enable/disable Simon Marchi
2016-03-31 10:58 ` Yao Qi [this message]
2016-03-31 18:01 ` Simon Marchi
2016-03-31 18:31 ` Simon Marchi
2016-04-01 13:36 ` Yao Qi
2016-04-01 14:42 ` Simon Marchi
2016-04-28 15:30 ` Simon Marchi
2016-04-28 16:03 ` Yao Qi
2016-04-28 16:57 ` Simon Marchi
2016-03-31 10:51 ` [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag Yao Qi
2016-03-31 11:33 ` Pedro Alves
2016-03-31 12:58 ` Yao Qi
2016-03-31 17:45 ` Simon Marchi
2016-05-05 7:58 ` Yao Qi
2016-05-05 13:50 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k2kirk18.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).