From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22660 invoked by alias); 22 Mar 2016 10:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22557 invoked by uid 89); 22 Mar 2016 10:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.67.30.163 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Mar 2016 10:14:55 +0000 Received: by mail-pf0-f193.google.com with SMTP id x3so34897516pfb.0 for ; Tue, 22 Mar 2016 03:14:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=uLuMEyvm3RpmYS4baEl4Tl9gJc5cBfmwSdyZ/JKN1LA=; b=Y2IXCTK1/f5SJWer0bmQrTPpfNmiBmhzDackwzHzf0LCSuxu/4zdDo6kayzKxN2vrp 8YFzGnns2rHXrLquP0DOy+ypLuPESJoHvWJWgv3sYr13BPls2KHS7Da7tjR4T2Rb4DSf d7o+C56ZRhc9T3Y2zxtIb7/jh91KMgWaNjYZDil3yd5GHM5v3klMjR+w0RT9w+P1aE4e qBvGcxEFKNGrokdNtcH23XCqgLKdsgNkU/vdlALaJ3fUuqD7G/bDRsjAW0nAWvbmJnLY u69Uc5Awfn2gKHdDDEBpk9dYY25/5pPFNvEYNWicQjqrzRx4IUf/CulPeLYERfGNgr0H WkPQ== X-Gm-Message-State: AD7BkJKBW+tE/ClliLiDcsmi/DydrjNR8+KSa5GXN/Is4sQW/bVSsMf7nsS7dMGeYLHQsg== X-Received: by 10.67.30.163 with SMTP id kf3mr52772592pad.45.1458641693603; Tue, 22 Mar 2016 03:14:53 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id to9sm47131845pab.27.2016.03.22.03.14.51 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 22 Mar 2016 03:14:52 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 22/25] Make main_ui be heap allocated References: <1458573675-15478-1-git-send-email-palves@redhat.com> <1458573675-15478-23-git-send-email-palves@redhat.com> Date: Tue, 22 Mar 2016 10:14:00 -0000 In-Reply-To: <1458573675-15478-23-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 21 Mar 2016 15:21:12 +0000") Message-ID: <86k2kuvmy3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00451.txt.bz2 Pedro Alves writes: > --- > gdb/event-top.c | 7 +++---- > gdb/main.c | 27 ++++++++++++--------------- > gdb/top.c | 37 +++++++++++++++++++++++++++++++++++++ > gdb/top.h | 5 +++++ > 4 files changed, 57 insertions(+), 19 deletions(-) > > diff --git a/gdb/event-top.c b/gdb/event-top.c > index 436edf7..69f6be7 100644 > --- a/gdb/event-top.c > +++ b/gdb/event-top.c > @@ -362,11 +362,10 @@ top_level_prompt (void) > return xstrdup (prompt); > } >=20=20 > -static struct ui main_ui_; >=20=20 > -struct ui *main_ui =3D &main_ui_; > -struct ui *current_ui =3D &main_ui_; > -struct ui *ui_list =3D &main_ui_; > +struct ui *main_ui; > +struct ui *current_ui; > +struct ui *ui_list; We need comments to "main_ui" and "current_ui". I am carrying a question "what is the main UI" since patch 06. --=20 Yao (=E9=BD=90=E5=B0=A7)