From: Yao Qi <qiyaoltc@gmail.com>
To: Pierre Langlois <pierre.langlois@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [AArch64] Fix incorrect mask when decoding b.cond instruction
Date: Fri, 11 Sep 2015 15:35:00 -0000 [thread overview]
Message-ID: <86k2rx55qi.fsf@gmail.com> (raw)
In-Reply-To: <1441963216-8139-1-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Fri, 11 Sep 2015 10:20:16 +0100")
Pierre Langlois <pierre.langlois@arm.com> writes:
> The encoding of the b.cond instruction is described in the architecture
> reference manual as:
>
> b.cond 0101 0100 iiii iiii iiii iiii iii0 cccc
>
> So the mask should be 0xff000010.
>
> I've regression tested it on aarch64-linux, I haven't seen any difference
> with or without the patch.
Hi Pierre,
You posted this patch here
https://sourceware.org/ml/gdb-patches/2015-08/msg00421.html and I
reviewed it. The patch is OK.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-09-11 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 9:20 Pierre Langlois
2015-09-11 15:35 ` Yao Qi [this message]
2015-09-11 15:52 ` Pierre Langlois
-- strict thread matches above, loose matches on Subject: below --
2015-08-17 13:29 Pierre Langlois
2015-08-19 8:32 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k2rx55qi.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.langlois@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).