public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 1/8] Disallow using --attach and --wrapper together.
Date: Fri, 24 Jul 2015 08:44:00 -0000	[thread overview]
Message-ID: <86k2tqgd2c.fsf@gmail.com> (raw)
In-Reply-To: <55B16AC0.4090808@redhat.com> (Pedro Alves's message of "Thu, 23	Jul 2015 23:29:20 +0100")

Pedro Alves <palves@redhat.com> writes:

> Really not sure about this.  It's reasonable to do e.g.,
> alias gs="gdbserver --wrapper=/whatever/wrapper --"
> (or the equivalent wrapper shell script that execs gdbserver)
> and then always start that instead of gdbserver:
>
> sometimes:
>
>  $ gs :9999 PROGRAM
>
> othertimes:
>
>  $ gs --attach :9999 $pid
>
> but after the patch, the latter errors out.

IMO, it makes sense to error out in the latter case, because --wrapper
is useless if GDBserver attaches to a process.

>
> Plus, one can combine --attach and --multi, which means
> that the wrapper would still apply to processes spawned
> after connecting.

I agree on this case.  I withdraw this patch.

-- 
Yao (齐尧)

  reply	other threads:[~2015-07-24  8:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 11:35 [PATCH 0/8] Fix various issues in --wrapper in GDBserver Yao Qi
2015-07-20 11:35 ` [PATCH 2/8] Test --wrapper in extended-remote Yao Qi
2015-07-23 22:35   ` Pedro Alves
2015-07-20 11:35 ` [PATCH 1/8] Disallow using --attach and --wrapper together Yao Qi
2015-07-23 22:29   ` Pedro Alves
2015-07-24  8:44     ` Yao Qi [this message]
2015-07-24  8:51       ` Pedro Alves
2015-07-20 11:35 ` [PATCH 4/8] Test --wrapper when restarting process Yao Qi
2015-07-23 22:59   ` Pedro Alves
2015-07-20 11:36 ` [PATCH 3/8] Set general_thread after restart Yao Qi
2015-07-23 22:58   ` Pedro Alves
2015-07-24  9:33     ` Yao Qi
2015-07-24  9:53       ` Pedro Alves
2015-07-24 11:31         ` Yao Qi
2015-07-20 11:36 ` [PATCH 7/8] Initialise target descrption after skipping extra traps for --wrapper Yao Qi
2015-07-23 23:26   ` Pedro Alves
2015-07-24 11:12     ` Yao Qi
2015-07-24 11:52       ` Pedro Alves
2015-07-24 13:08         ` Yao Qi
2015-07-24 13:44           ` Pedro Alves
2015-07-20 11:36 ` [PATCH 5/8] Refactor start_inferior Yao Qi
2015-07-23 23:27   ` Pedro Alves
2015-07-20 11:36 ` [PATCH 8/8] Remove proc->priv->new_inferior Yao Qi
2015-07-23 23:27   ` Pedro Alves
2015-07-20 11:36 ` [PATCH 6/8] Set proc->priv->new_inferior out of linux_add_process Yao Qi
2015-07-23 23:26   ` Pedro Alves
2015-07-24 13:49 ` [PATCH 0/8] Fix various issues in --wrapper in GDBserver Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k2tqgd2c.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).