* [PATCH] Remove a MAX_REGISTER_SIZE from frame.c
@ 2017-06-05 16:33 Alan Hayward
2017-06-06 15:30 ` Yao Qi
0 siblings, 1 reply; 2+ messages in thread
From: Alan Hayward @ 2017-06-05 16:33 UTC (permalink / raw)
To: gdb-patches; +Cc: nd
Make frame_unwind_register_signed look the same as
frame_unwind_register_unsigned.
This change got missed in a previous patch.
Tested on a --enable-targets=all build using make check with board files
unix and native-gdbserver.
Ok to commit?
Alan.
2017-06-05 Alan Hayward <alan.hayward@arm.com>
* frame.c (frame_unwind_register_signed): Use
frame_unwind_register_value.
diff --git a/gdb/frame.c b/gdb/frame.c
index efe5a20591dd2667200f85e0cff07dbe79ee3e87..30e4aeab7e2901074c289ac4d96ebda885805a29 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1252,10 +1252,27 @@ frame_unwind_register_signed (struct frame_info *frame, int regnum)
struct gdbarch *gdbarch = frame_unwind_arch (frame);
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
int size = register_size (gdbarch, regnum);
- gdb_byte buf[MAX_REGISTER_SIZE];
+ struct value *value = frame_unwind_register_value (frame, regnum);
+
+ gdb_assert (value != NULL);
+
+ if (value_optimized_out (value))
+ {
+ throw_error (OPTIMIZED_OUT_ERROR,
+ _("Register %d was not saved"), regnum);
+ }
+ if (!value_entirely_available (value))
+ {
+ throw_error (NOT_AVAILABLE_ERROR,
+ _("Register %d is not available"), regnum);
+ }
- frame_unwind_register (frame, regnum, buf);
- return extract_signed_integer (buf, size, byte_order);
+ LONGEST r = extract_signed_integer (value_contents_all (value), size,
+ byte_order);
+
+ release_value (value);
+ value_free (value);
+ return r;
}
LONGEST
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove a MAX_REGISTER_SIZE from frame.c
2017-06-05 16:33 [PATCH] Remove a MAX_REGISTER_SIZE from frame.c Alan Hayward
@ 2017-06-06 15:30 ` Yao Qi
0 siblings, 0 replies; 2+ messages in thread
From: Yao Qi @ 2017-06-06 15:30 UTC (permalink / raw)
To: Alan Hayward; +Cc: gdb-patches, nd
Alan Hayward <Alan.Hayward@arm.com> writes:
> Ok to commit?
>
> Alan.
>
>
> 2017-06-05 Alan Hayward <alan.hayward@arm.com>
>
> * frame.c (frame_unwind_register_signed): Use
> frame_unwind_register_value.
Looks good to me.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-06 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 16:33 [PATCH] Remove a MAX_REGISTER_SIZE from frame.c Alan Hayward
2017-06-06 15:30 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).