From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 923BA3858C55 for ; Sun, 3 Mar 2024 08:56:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 923BA3858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 923BA3858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709456189; cv=none; b=Uq9nH9lhUlj0tz1pdKT8PG+Ov6CoS2JgXrc5Co4RNPrgU2+T+ynWd88luMPHRxnxKteJCvqxmIlgxNkpCMvU+76my5E+Oog8W93fy4/LPUHXGjiz5CBjZQACzS46QC+Z+GnSpN+Dd8NCowgMqwjwFdz4w+9+u2iZhKlazqlaMR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709456189; c=relaxed/simple; bh=o64gyEfows3EcoR95PSU/qDLcNOY2IVQ8SfKWRkhVdE=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=b4Wld+A+Z1lQF3Cm1Pdd//H8gxdVz280tSBL9HXGvOfmEjiGL9s2ef/i5iCm27svImz6ljCoHsxrehh8cq0HEw+sHyEVboP7ocfE6ChJWSPnv40iWzYd4bQe/MCYzSyo8rmYqruamyMCNCaHXXTFbri3LeGmYhWBsacsM3vr0Bo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rghdw-0005dD-SU; Sun, 03 Mar 2024 03:56:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xs6EcVpzf6gX0ECRaQE6kwyHQ1Ru7VQbQSSQV1/y7BE=; b=K4vYfdbWqoWh bPhgnFn7E4efFZbP6farD4vOUkapCkM1bTIqFWJEDvCwD/qIfVKWOwTpzbdjBlW0NToNYsnCZcR7O bCEyRDkV0vr+T/Eb1jNm5f+ETELIho0IqIhIdpPSNPUyAWIRhz+OYR3iW7skWarf0kXLkSlDa2GZW bKbSqq0D59GAer7a6gXbc4eXDrlnYk9jcGYR7324oRRRQEb6WOdrjGemXIDjVV7uxahGj4oXXKZF6 z8KJXvukStcE1B68OfGYSBNXv/SLTyBpKdnuas2ffrozbY43C6fCYc92mMuWNWx0+JsmDktPXYtjB 8BR2x7E5VpPZaBVTkVTpQQ==; Date: Sun, 03 Mar 2024 10:56:21 +0200 Message-Id: <86msrfofre.fsf@gnu.org> From: Eli Zaretskii To: Orgad Shaneh Cc: gdb-patches@sourceware.org In-Reply-To: <20240303075907.1188-1-orgad.shaneh@audiocodes.com> (message from Orgad Shaneh on Sun, 3 Mar 2024 09:58:58 +0200) Subject: Re: [PATCH] Support MSYS platform References: <20240303075907.1188-1-orgad.shaneh@audiocodes.com> X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Orgad Shaneh > Cc: Orgad Shaneh > Date: Sun, 3 Mar 2024 09:58:58 +0200 > > From: Orgad Shaneh > > Apply MSYS patches upstream. Thanks. Please find a few comments below. But before that: what exactly is the MSYS target, and how does it differ from MinGW and Cygwin targets? In addition, I think this warrants a NEWS entry (both for Binutils and for GDB). > diff --git a/configure b/configure > index dd743c58663..51c7d7b0b20 100755 > --- a/configure > +++ b/configure > @@ -1534,12 +1534,12 @@ Optional Features: > --disable-FEATURE do not include FEATURE (same as --enable-FEATURE=no) > --enable-FEATURE[=ARG] include FEATURE [ARG=yes] > --enable-as-accelerator-for=ARG > - build as offload target compiler. Specify offload > + build as offload target compiler. Specify offload > host triple by ARG > --enable-offload-targets=LIST > enable offloading to devices from comma-separated > - LIST of TARGET[=DIR]. Use optional path to find > - offload target compiler during the build > + LIST of TARGET[=DIR]. Use optional path to find > + offload target compiler during the build > --enable-offload-defaulted What are those ^M (CR) characters, here and elsewhere? Looks like some artifact of the way you produced the diffs? > @@ -4502,7 +4503,7 @@ cat confdefs.h - <<_ACEOF >conftest.$ac_ext > /* end confdefs.h. */ > > int > -main () > +main (void) > { Why is this needed? Did you use some version of Autotools that produces these differences? General comment: some of the sources patched in this series are maintained elsewhere: Readline is maintained by Bash, Libtool is maintained by its own project, etc. So I expect you will need to submit the relevant parts to their upstream projects.