Hi Andrew,

Andrew Burgess <aburgess@redhat.com> writes:

> An ideal commit message body should be readable without having to read
> the title.  I notice you don't actually mention 'vsplit' in the body at
> all!

Hmm, I never thought about reading the body separate of the summary line
(just the inverse, reading the summary without the body present).  What
do you think of the following:

--8<---------------cut here---------------start------------->8---
The new 'vsplit' layout is analogous to the old 'split' TUI layout, but
instead of splitting the screen into three horizontal sections, it
splits the screen into two, and then the top of the split into two,
where the top left pane is source and the top right pane is assembly,
and the bottom pane is the command pane, with a status line between the
top two and the bottom panes.  This allows GDB to better utilize screen
real-estate on wide-screen displays that are commonly used nowadays.

A crude drawing of this layout looks like:

   +---------------+---------------+
   |               |               |
   |      Src      |      Asm      |
   |               |               |
   +---------------+---------------+
   | Status Line                   |
   +-------------------------------+
   |                               |
   |      Command Pane             |
   |                               |
   +-------------------------------+
--8<---------------cut here---------------end--------------->8---

> Also, the name seems a little odd (to me), you even say:
>
>   > The usual 'split' layout features a vertical stack...
>
> And
>
>   > This [new 'vsplit'] layout displays the same information but in a
>   > horizontal stack...
>
> So I'd have thought 'hsplit' would be a more natural name?

The stack is horizontal, but the 'main' split on the screen is vertical
(hence, 'vertically split' => 'vsplit').

> Also, I have to ask, as you've not mentioned it in the commit message.
> Did you know that you can add this line to your ~/.gdbinit file?
>
>   tui new-layout vsplit { -horizontal src 1 asm 1 } 1 status 1 cmd 1
>
> And now you have the vsplit layout you want.  This feature was added in
> part (I believe) to remove the need for every possible layout to be
> added into GDB core.  Did you consider this as an option?

Yes, I have it already.  This layout was even already in the testsuite!
I shared the story of how this patch came to be in v1:
https://inbox.sourceware.org/20231104014343.3199584-1-arsen@aarsen.me/

I was also initially double-thinking sending this patch in, but I
figured that if multiple people use it, and if it's similar in spirit to
existing layouts, it's probably not /too/ redundant.

Naturally, if you disagree, that's alright - this is just a suggestion.

Thanks, have a lovely day :-)
-- 
Arsen Arsenović