From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16636 invoked by alias); 16 May 2017 13:50:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16326 invoked by uid 89); 16 May 2017 13:50:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HX-Received:10.99.149.20, Hx-languages-length:513, essentially X-HELO: mail-pf0-f172.google.com Received: from mail-pf0-f172.google.com (HELO mail-pf0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 13:50:19 +0000 Received: by mail-pf0-f172.google.com with SMTP id e193so80739821pfh.0 for ; Tue, 16 May 2017 06:50:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KMsueIZGOWeK5AN9uxDuooBxyUirPXK2i9dmFmtD83g=; b=e0jOmjl0EkD6Ut666a/mb3NJoWtulHd+c6sDVzeACXjkY7vUee7CYGZKds0a3mVh9M szf20N6iID6Q86IDnzj2kHcNGkUHuSD6FpAws5XFXMY6dPBOPHVGwkQ/cKe6eN9P9cI2 vZ/kc8R5LnUZxxJODH54sH29PQyi6Tp9XSR7yHFZYdJECmIrebj28h61PYLRsfmM4nqR HcBW1h7HFghtCyuPCzdR9+JascEyIHDkNfwYQuUPsvTwbXPGUH7t/q8uMPg38tal6Cj3 D5JqNBcLNeue/l0vDADFcxkqR4EDltpOYuVIecWAkTKN90IKxyGibN4+oe4ChlcYq8qk 9EPQ== X-Gm-Message-State: AODbwcC4dmHcN8O3pQDuaAVKw9trniv+OTo4gCOM7zhy9Jix/HDOhUlf WZmRrAIq4p0BFYmR X-Received: by 10.99.149.20 with SMTP id p20mr12099660pgd.112.1494942621174; Tue, 16 May 2017 06:50:21 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id d6sm25742503pfk.90.2017.05.16.06.50.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 16 May 2017 06:50:20 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/19] PR gdb/21226: Take DWARF stack value pieces from LSB end References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-4-git-send-email-arnez@linux.vnet.ibm.com> <86wp9icvnn.fsf@gmail.com> <86d1b9b5kf.fsf@gmail.com> Date: Tue, 16 May 2017 13:50:00 -0000 In-Reply-To: (Andreas Arnez's message of "Tue, 16 May 2017 13:49:41 +0200") Message-ID: <86mvacap2g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00345.txt.bz2 Andreas Arnez writes: > I mean this part of the logic: > > if (n > c->addr_size - source_offset) > n =3D (c->addr_size >=3D source_offset > ? c->addr_size - source_offset > : 0); > if (n =3D=3D 0) > { > /* Nothing. */ > } > else ... > > Which can essentially be translated into > > if (n =3D=3D 0 || source_offset >=3D c->addr_size) > break; > ... OK, I see what you mean now. The patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)