From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 543 invoked by alias); 15 Jul 2015 14:01:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 505 invoked by uid 89); 15 Jul 2015 14:01:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f176.google.com Received: from mail-pd0-f176.google.com (HELO mail-pd0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Jul 2015 14:01:06 +0000 Received: by pdbep18 with SMTP id ep18so26523277pdb.1 for ; Wed, 15 Jul 2015 07:01:04 -0700 (PDT) X-Received: by 10.68.206.68 with SMTP id lm4mr8491709pbc.147.1436968864415; Wed, 15 Jul 2015 07:01:04 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id s1sm4829139pda.54.2015.07.15.07.01.02 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 15 Jul 2015 07:01:03 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [AArch64] Mark single precision pseudo registers unavailable if invalid References: <1436957554-1403-1-git-send-email-pierre.langlois@arm.com> Date: Wed, 15 Jul 2015 14:01:00 -0000 In-Reply-To: <1436957554-1403-1-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Wed, 15 Jul 2015 11:52:34 +0100") Message-ID: <86mvyxjzah.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00434.txt.bz2 Pierre Langlois writes: > It turns out GDB does not check if S registers are valid before returning > a value for them. It should return in this case. Yes, your fix is correct, however ... > > Thanks, > Pierre > > gdb/ChangeLog: > > * aarch64-tdep.c (aarch64_pseudo_read_value): Mark S register as > unavailable if invalid. ... when I read your patch, I am wondering why does aarch64 implement gdbarch method pseudo_register_read_value rather than pseudo_register_read. If we implement the pseudo_register_read, the caller will mark the value unavailable according to its return value. pseudo_register_read_value was added to handle partially available registers by https://sourceware.org/ml/gdb-patches/2011-07/msg00351.html but I don't think of a case that some aarch64 register is partially available. Maybe, another fix to this problem is to implement pseudo_register_read instead of pseudo_register_read_value. --=20 Yao (=E9=BD=90=E5=B0=A7)