From: "Arsen Arsenović" <arsen@aarsen.me>
To: Andreas Schwab <schwab@suse.de>
Cc: "Arsen Arsenović via Binutils" <binutils@sourceware.org>,
gdb-patches@sourceware.org, "Bruno Haible" <bruno@clisp.org>,
"Iain Sandoe" <iain@sandoe.co.uk>
Subject: Re: [PATCH 2/2] *: suppress xgettext 0.22 charset name error
Date: Mon, 25 Sep 2023 17:55:20 +0200 [thread overview]
Message-ID: <86o7hqz16y.fsf@aarsen.me> (raw)
In-Reply-To: <mvmcyy6s1bt.fsf@suse.de>
[-- Attachment #1: Type: text/plain, Size: 2010 bytes --]
Andreas Schwab <schwab@suse.de> writes:
> On Sep 25 2023, Arsen Arsenović via Binutils wrote:
>
>> libctf/ChangeLog:
>>
>> * po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot
>> temporary file to suppress xgettext checking charset names.
>
> There is no po/Make-in in libctf.
Seems to have been an error when I was filling the changelog entries.
The libctf changelog should be:
* Makefile.am (SUBDIRS): Define to empty to suppress Automake
stating 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not
defined'
... which also covers your latter comment.
>
>> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am
>> index 00524e9a566..43aa670faf4 100644
>> --- a/gdbsupport/Makefile.am
>> +++ b/gdbsupport/Makefile.am
>> @@ -19,6 +19,7 @@
>>
>> AUTOMAKE_OPTIONS = no-dist foreign
>> ACLOCAL_AMFLAGS = -I . -I ../config
>> +SUBDIRS =
>>
>> AM_CPPFLAGS = -I$(srcdir)/../include -I$(srcdir)/../gdb \
>> -I../gnulib/import -I$(srcdir)/../gnulib/import \
>
> Spurious change.
This has the same rationale as the libctf change above.
>> diff --git a/libctf/Makefile.am b/libctf/Makefile.am
>> index b1dbc2f6ba4..8c9f623f58c 100644
>> --- a/libctf/Makefile.am
>> +++ b/libctf/Makefile.am
>> @@ -17,6 +17,8 @@
>> # <http://www.gnu.org/licenses/>.
>> #
>>
>> +SUBDIRS =
>> +
>> ACLOCAL_AMFLAGS = -I .. -I ../config -I ../bfd
>>
>> AUTOMAKE_OPTIONS = dejagnu foreign info-in-builddir no-texinfo.tex
>
> Likewise.
These directories utilize ZW_GNU_GETTEXT_SISTER_DIR to get information
about where gettext is despite never having any translations of their
own, leading to the Automake warning above.
Apologies for the ChangeLog confusion, it must've been late when I was
splitting and merging commits, and so I mislabeled and mismerged some
changes. I can split this patch into two if you agree, and fix the
libctf ChangeLog entry.
Thanks, have a lovely day.
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
next prev parent reply other threads:[~2023-09-25 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:13 [PATCH 0/2] Replace intl/ with out-of-tree GNU gettext Arsen Arsenović
2023-09-25 15:13 ` [PATCH 1/2] *: add modern gettext support Arsen Arsenović
2023-09-25 15:13 ` [PATCH 2/2] *: suppress xgettext 0.22 charset name error Arsen Arsenović
2023-09-25 15:46 ` Andreas Schwab
2023-09-25 15:55 ` Arsen Arsenović [this message]
2023-09-25 19:11 ` [PATCH 0/2] Replace intl/ with out-of-tree GNU gettext Kevin Buettner
2023-09-25 19:43 ` Arsen Arsenović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7hqz16y.fsf@aarsen.me \
--to=arsen@aarsen.me \
--cc=binutils@sourceware.org \
--cc=bruno@clisp.org \
--cc=gdb-patches@sourceware.org \
--cc=iain@sandoe.co.uk \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).