From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89299 invoked by alias); 20 Jan 2016 10:19:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89284 invoked by uid 89); 20 Jan 2016 10:18:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=gdbtesters, gdb-testers, Dynamic, Hx-spam-relays-external:209.85.192.194 X-HELO: mail-pf0-f194.google.com Received: from mail-pf0-f194.google.com (HELO mail-pf0-f194.google.com) (209.85.192.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 20 Jan 2016 10:18:58 +0000 Received: by mail-pf0-f194.google.com with SMTP id n128so203613pfn.3 for ; Wed, 20 Jan 2016 02:18:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=bfS/3piV3tArIA1b+Rf68bdwrQIxnsQcKhdpElENtwM=; b=KpQhz81Ia4ecHxoG12L4GFLoXXo/zVMyOcH53wJX2U38npTC8YrZlPLHzxwIKmr8+P LLah2PcvAO7ggUZejIV96n2WlesMY6AXWC20UecaLjyBpvOoGxZzEgTxdU64fy6WYSla PTjSk0/O3cvN5w/qBneDaWh1hEAD9eu8et74wV7/O3zPM0i0Jr+xjpu6GkxZNMEMKgEc t4p4zsg86Ne4IiQcvNyY+UQSMJjy+8pwUDX/w29X7HswaPYWKBq03s2xlsnXEQwBT9vt ETRB8UNf6I/5RB0ZFzv1X8/6YIu/prleNdrKIxhQdeSROBtYZSKsIy1QLwDpOXa1D+uF bChQ== X-Gm-Message-State: ALoCoQmizq4hN6minVWF3YkGPmtOdnCdKbKqwwRwIWnUP3DGkgYGlhsmY3iN6xCScxG1iURMet9AlMgIOgCQwgZm59FBHbd/kw== X-Received: by 10.98.42.88 with SMTP id q85mr51367357pfq.1.1453285136787; Wed, 20 Jan 2016 02:18:56 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id o81sm47583694pfi.92.2016.01.20.02.18.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 20 Jan 2016 02:18:55 -0800 (PST) From: Yao Qi To: Keven Boell Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH 1/2] fort_dyn_array: add basic fortran dyn array support References: <1435754532-17922-1-git-send-email-keven.boell@intel.com> <1435754532-17922-2-git-send-email-keven.boell@intel.com> <20150721180502.GN7406@adacore.com> <55C213C7.7070202@linux.intel.com> <20150805202301.GB14992@adacore.com> <51130.172.28.205.135.1438861308.squirrel@linux.intel.com> <20150820125159.GD4571@adacore.com> <5617A6FB.4050407@linux.intel.com> Date: Wed, 20 Jan 2016 10:19:00 -0000 In-Reply-To: <5617A6FB.4050407@linux.intel.com> (Keven Boell's message of "Fri, 9 Oct 2015 13:37:31 +0200") Message-ID: <86oacgsgdx.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00467.txt.bz2 Keven Boell writes: > Fortran provide types whose values may be dynamically allocated > or associated with a variable under explicit program control. > The purpose of this commit is > * to read allocated/associated DWARF tags and store them in > the dynamic property list of main_type. > * enable GDB to print the value of a dynamic array in Fortran > in case the type is allocated or associated (pointer to > dynamic array). > > Examples: > (gdb) p vla_not_allocated > $1 =3D > > (gdb) p vla_allocated > $1 =3D (1, 2, 3) > > (gdb) p vla_ptr_not_associated > $1 =3D > > (gdb) p vla_ptr_associated > $1 =3D (1, 2, 3) > > Add basic test coverage for most dynamic array use-cases > in Fortran. > The commit contains the following tests: > * Ensure that values of Fortran dynamic arrays > can be evaluated correctly in various ways and states. > * Ensure that Fortran primitives can be evaluated > correctly when used as a dynamic array. > * Dynamic arrays passed to subroutines and handled > in different ways inside the routine. > * Ensure that the ptype of dynamic arrays in > Fortran can be printed in GDB correctly. > * Ensure that dynamic arrays in different states > (allocated/associated) can be evaluated. > * Dynamic arrays passed to functions and returned from > functions. > * History values of dynamic arrays can be accessed and > printed again with the correct values. > * Dynamic array evaluations using MI protocol. > * Sizeof output of dynamic arrays in various states. > > The patch was tested using the test suite on Ubuntu 12.04 64bit. Hi Keven, The test cases added by this commit fail on some other OS and targets, see this thread, https://sourceware.org/ml/gdb-testers/2015-q4/msg02136.html can you take a look? --=20 Yao (=E9=BD=90=E5=B0=A7)