From: Yao Qi <qiyaoltc@gmail.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v8 3/7] Refactor arm_software_single_step to use regcache
Date: Mon, 18 Jan 2016 10:35:00 -0000 [thread overview]
Message-ID: <86oacjtbue.fsf@gmail.com> (raw)
In-Reply-To: <1450361684-29536-4-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Thu, 17 Dec 2015 09:14:40 -0500")
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> This patch is in preparation for software single step support on ARM in
> GDBServer. It refactors arm_*_software_single_step and sub-functions to
> use regcache instead of frame to access registers so that the code can be
> shared more easily between GDB and GDBServer.
>
> Note also that since the intention is at some point to get rid of frame
> completely in that function, memory reads have also been replaced by
> read_memory_unsigned_integer rather than get_frame_memory_unsigned.
>
> No regressions, tested on ubuntu 14.04 ARMv7 and x86.
> With gdbserver-{native,extended} / { -marm -mthumb }
As a record, this patch causes regressions at least in
gdb.base/sigstep.exp,
(gdb) PASS: gdb.base/sigstep.exp: continue to handler, si+advance in handler, step from handler: advance in handler
step^M
39 } /* handler */^M
1: x/i $pc^M
=> 0x8740 <handler+80>: sub sp, r11, #0^M
(gdb) step^M
^M
Program received signal SIGSEGV, Segmentation fault.^M
setitimer () at ../sysdeps/unix/syscall-template.S:81^M
81 ../sysdeps/unix/syscall-template.S: No such file or directory.^M
1: x/i $pc^M
=> 0xb6eff9c0 <setitimer>: push {r7}^M
(gdb) FAIL: gdb.base/sigstep.exp: continue to handler, si+advance in handler, step from handler: leave handler
Could you take a look at it?
--
Yao (齐尧)
next prev parent reply other threads:[~2016-01-18 10:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:14 [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM in GDBServer Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 1/7] Replace breakpoint_reinsert_addr by get_next_pcs operation " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 2/7] Share some ARM target dependent code from GDB with GDBServer Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 5/7] Support software single step on ARM in GDBServer Antoine Tremblay
2015-12-21 13:58 ` Yao Qi
2016-01-04 12:59 ` Antoine Tremblay
2016-01-06 14:23 ` Yao Qi
2016-01-06 14:36 ` Antoine Tremblay
2016-01-06 14:56 ` Yao Qi
2016-01-06 14:58 ` Antoine Tremblay
2016-01-06 14:42 ` Yao Qi
2016-01-06 14:50 ` Antoine Tremblay
2016-01-06 15:04 ` Yao Qi
2016-01-13 16:13 ` Yao Qi
2016-01-13 19:10 ` Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 7/7] Enable conditional breakpoints for targets that support software single step " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 6/7] Enable software single stepping for while-stepping actions " Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 4/7] Share regcache function regcache_raw_read_unsigned Antoine Tremblay
2015-12-17 14:15 ` [PATCH v8 3/7] Refactor arm_software_single_step to use regcache Antoine Tremblay
2016-01-18 10:35 ` Yao Qi [this message]
2016-01-18 13:07 ` Yao Qi
2016-01-18 14:02 ` Antoine Tremblay
2016-01-21 7:52 ` Yao Qi
2015-12-18 12:56 ` [PATCH v8 0/7] Support software single step and conditional breakpoints on ARM in GDBServer Antoine Tremblay
2015-12-18 16:45 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86oacjtbue.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).