Re: [PATCH 1/2] gdb: avoid '//' in filenames when searching for debuginfo

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: tom@tromey.com, gdb-patches@sourceware.org
> Date: Sat, 15 Jun 2024 11:24:13 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> Our inputs:
> 
> File we're debugging:	d:/foo/bar/file
> Debug link name:	file.debug
> DEBUG_SUBDIRECTORY:	.debug
> debug-file-directory:   x:/baz/quux/
> sysroot:                d:/foo/
> 
> Locations checked for debug, in this order:
> 
>   1. d:/foo/bar/file.debug
>   2. d:/foo/bar/.debug/file.debug
>   3. x:/baz/quux/d/foo/bar/file.debug
>   4. x:/baz/quux/bar/file.debug
>   5. d:/foo/x:/baz/quux/bar/file.debug
> 
> Of these, only (5) is obviously wrong I think as it didn't consider that
> the debug-file-directory might be an absolute path on a DOS based host.
> This code was introduced in commit:
> 
>   commit 402d2bfec425f29c5b54089d5ff98ca9a1b8ec27
>   Date:   Tue Feb 12 13:56:16 2019 -0800
>   
>       Look for separate debug files in debug directories under a sysroot.

That should be fixed, IMO.

> As far as _this_ commit is concerned the _only_ change that might impact
> DOS based hosts is that, when joining absolute paths, I convert every
> instance of "//" within a path to "/".  This only happens for paths
> after the fist one though, so if the first path starts with
> "//server/file" that will remain as it is.  But if we try to do this:
> 
>   combine_paths ("//server_a/aaa", "//server_b/bbb")
> 
> then we'd get:
> 
>   "//server_a/aaa/server_b/bbb"
> 
> which might not be what we want.

Given that we convert d:/ into d/ for the purposes of concatenation, I
think "//server_a/aaa/server_b/bbb" _is_ what we want.

> Dealing with UNC paths in general is going to require more extensive
> work I suspect.

Maybe, but right now it sounds like we are either already close or
maybe even there.

Thanks.