From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] Decouple ARM instruction decoding/relocating from GDB
Date: Fri, 04 Mar 2016 12:03:00 -0000 [thread overview]
Message-ID: <86pova8n6u.fsf@gmail.com> (raw)
In-Reply-To: <1456415245-24005-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 25 Feb 2016 10:47:23 -0500")
Simon Marchi <simon.marchi@ericsson.com> writes:
Hi Simon,
> As part of the upcoming ARM fast tracepoint support, we need to have some code
> in gdbserver that decodes the relocated instructions, to check whether they
> need to be modified or not (whether the result of their execution depends on
> their particular PC). Instead of writing new code from scratch, we should take
> advantage of the code already written for the displaced stepping feature in
> GDB, as AArch64 does. To make this possible, we first need to decouple the
> instruction decoding part from GDB, so that the code can eventually be moved to
> a shared location.
Could you include these two patches into your arm fast tracepoint patch
series? The problems in the code can't be found until we use the code,
so I'd like to review them together when arm fast tracepoint patches are
ready.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-03-04 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 15:47 Simon Marchi
2016-02-25 15:47 ` [PATCH 1/2] arm-tdep.c: Replace arguments to relocation functions by a structure Simon Marchi
2016-02-26 16:12 ` Luis Machado
2016-02-26 16:25 ` Simon Marchi
2016-02-26 16:26 ` Simon Marchi
2016-02-25 15:47 ` [PATCH 2/2] arm-tdep.c: Refactor displaced stepping relocation functions Simon Marchi
2016-02-26 16:11 ` Luis Machado
2016-02-26 16:23 ` Simon Marchi
2016-02-26 16:50 ` Luis Machado
2016-03-04 12:03 ` Yao Qi [this message]
2016-03-04 18:42 ` [PATCH 0/2] Decouple ARM instruction decoding/relocating from GDB Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pova8n6u.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).